Skip to content

Commit 0a87d1b

Browse files
address some review comments
Signed-off-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>
1 parent 15ad935 commit 0a87d1b

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

pkg/intoto/metadata.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ import (
1212
// Metadata points to root layout, its public keys, and/or links
1313
type Metadata struct {
1414
Data []byte `json:"data"`
15-
PublicKeys []string `json:"public-keys"` // filenames
16-
Links []string `json:"links"` // filenames
15+
PublicKeys []string `json:"pubkeys"` // filenames
16+
Links []string `json:"links"` // filenames
1717
}
1818

1919
// Custom is a generic structure that contains in-toto Metadata
2020
type Custom struct {
21-
InToto Metadata `json:"in-toto"`
21+
InToto Metadata `json:"intoto"`
2222
}
2323

2424
// PublicKeys is a map from the GUN-qualified filename

pkg/tuf/common.go

-6
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
// Most of the helper functions are adapted from github.com/theupdateframework/notary
2-
//
3-
// Figure out the proper way of making sure we are respecting the licensing from Notary
4-
// While we are also vendoring Notary directly (see LICENSE in vendor/github.com/theupdateframework/notary/LICENSE),
5-
// copying unexported functions could fall under different licensing, so we need to make sure.
6-
71
package tuf
82

93
import (

pkg/tuf/common_test.go

-1
This file was deleted.

pkg/tuf/sign.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ func reuseKeys(repo client.Repository, rootKey string) error {
185185
}
186186

187187
default:
188-
return fmt.Errorf("cannot list targets: %v", err)
188+
return fmt.Errorf("cannot list targets while reusing keys: %v", err)
189189
}
190190
}
191191
return nil

0 commit comments

Comments
 (0)