Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm.js is bundled twice in node_modules #1683

Open
jelly opened this issue Jun 17, 2024 · 1 comment
Open

xterm.js is bundled twice in node_modules #1683

jelly opened this issue Jun 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jelly
Copy link
Member

jelly commented Jun 17, 2024

Use esbuild's bundle analyzer to analyse the bundle information created with ./build.js --metafile meta.json and analyse it here https://esbuild.github.io/analyze/

The import path xterm resolves to multiple files in the bundle:
    [node_modules/@patternfly/react-console/node_modules/xterm/lib/xterm.js](javascript:void 0)
    [node_modules/xterm/lib/xterm.js](javascript:void 0)
@jelly jelly added the bug Something isn't working label Jun 17, 2024
@jelly
Copy link
Member Author

jelly commented Jun 17, 2024

[jelle@t14s][~/projects/cockpit-machines]%npm ls xterm
machines@ /home/jelle/projects/cockpit-machines
├─┬ @patternfly/react-console@5.0.0
│ ├─┬ xterm-addon-fit@0.2.1
│ │ └── xterm@4.19.0 deduped
│ └── xterm@4.19.0
├─┬ xterm-addon-canvas@0.5.0
│ └── xterm@5.1.0 deduped
└── xterm@5.1.0

So we have two different versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant