Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The description is not entirely displayed if the description is too long during setting the VM description #1888

Open
yunmingyang opened this issue Nov 1, 2024 · 4 comments · May be fixed by #1901
Open

The description is not entirely displayed if the description is too long during setting the VM description #1888

yunmingyang opened this issue Nov 1, 2024 · 4 comments · May be fixed by #1901
Assignees
@mvollmer

Comments

@yunmingyang
Copy link
Contributor

Description of problem:
When setting the VM description, if the string is too long, the description may not be entirely displayed

Version-Release number of selected components (if applicable):
cockpit-machines-322-11-g63ac3f46
@mvollmer
Copy link
Member

mvollmer commented Nov 1, 2024

This is too vague.

@mvollmer mvollmer closed this as completed Nov 1, 2024
@yunmingyang
Copy link
Contributor Author

Screenshot from 2024-11-04 13-51-54
@mvollmer please see the picture, this description is 400 length 's', and you could see that the description is not fully displayed. So maybe we could compress the description, and instread with a hint, maybe like that
Screenshot from 2024-11-04 14-48-22
Not sure whether patterfly has a internal style to implement that

@martinpitt martinpitt reopened this Nov 4, 2024
@garrett
Copy link
Member

garrett commented Nov 5, 2024

FWIW: The description shouldn't truncate arbitrarily, but should wrap around.

@mvollmer
Copy link
Member

please see the picture, this description is 400 length 's', and you could see that the description is not fully displayed.

Ah, I see, thanks! Please try to provide concrete steps for reproduction in the future. Screenshots are indeed very helpful.

@mvollmer mvollmer self-assigned this Nov 11, 2024
mvollmer added a commit to mvollmer/cockpit-machines that referenced this issue Nov 11, 2024
@mvollmer
Improve rendering of VM descriptions
d9d9051 
Render the description as a single paragraph, with preserved line
breaks and word breaking on overflow.

Fixes cockpit-project#1888, cockpit-project#1890.
@mvollmer mvollmer linked a pull request Nov 11, 2024 that will close this issue
Open
mvollmer added a commit to mvollmer/cockpit-machines that referenced this issue Nov 11, 2024
@mvollmer
vm: Improve rendering of VM descriptions
4b430e8 
Render the description as a single paragraph, with preserved line
breaks and word breaking on overflow.

Fixes cockpit-project#1888, cockpit-project#1890.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvollmer mvollmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rendering of VM descriptions mvollmer/cockpit-machines
4 participants
@garrett @martinpitt @mvollmer @yunmingyang