ADD-01 MitigationConfirmed

[c4-bot-4]

Lines of code

Vulnerability details

C4 Issue

G06 : Switch the order of if statement to fail early saves 1 function call half of the times where function have SLOAD (Saves ~2100 Gas Half of the times)

G02 : Optimization Proposal for Withdraw Function in MagicSpend Contract

Mitigation

Gas optimization are correctly implemented as suggested.
Main point being the different order of operation/checks consumes less gas.

Changes are included into PR16

From the difference in gas snapshot there is a slightly decrease of gas usage for the patched version which is to be expected.

Conclusions

Successful Mitigation

[c4-judge]

3docSec marked the issue as satisfactory