Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-01 MitigationConfirmed #24

Open
c4-bot-2 opened this issue Sep 17, 2024 · 1 comment
Open

M-01 MitigationConfirmed #24

c4-bot-2 opened this issue Sep 17, 2024 · 1 comment
Labels
mitigation-confirmed MR-M-01 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-2
Copy link
Contributor

Lines of code

Vulnerability details

Original issue

Governance can adjust the DAO fee by adding or removing the RSR token as a distribution target.

Mitigation

The issue is properly addressed by preventing both RSR and RToken from being set as distribution targets.

function _setDistribution(address dest, RevenueShare memory share) internal {
    require(dest != address(0), "dest cannot be zero");
    require(
        dest != address(furnace) && dest != address(stRSR),
        "destination cannot be furnace or strsr directly"
    );
    require(
        dest != address(rsr) && dest != address(rToken),  // @audit, here
        "destination cannot be rsr or rToken"
    );
}
c4-bot-4 added a commit that referenced this issue Sep 17, 2024
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Sep 18, 2024
@c4-judge
Copy link

thereksfour marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-M-01 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants