ADD-01 MitigationConfirmed

[c4-bot-3]

Pull Request

This PR is an additional change that is in scope for this review and the purpose of the PR is to make EasyAuction address a detail of the GnosisTrade plugin.

After checking the 33 modified files (most especially Broker.sol, Deployer.sol, and GnosisTrade.sol), imo this has been correctly done since all expected changes have been made, from function declarations to deploy scripts, now all consider the EasyAuction address as a detail of the GnosisTrade plugin.

Edit:

Per the request here, an additional review has been made for the newly deployed EasyAuction contract here.

Per the third line in the file:

// ==== From https://etherscan.io/address/0x0b7ffc1f4ad541a4ed16b40d8c37f0929158d101 ====

We can see how this contract is an upgrade to this, using a gist file we can see that the only differences introduced to this new file is in form of indention, spacing and reduction of lines, without any change in the contract logic, see this: https://gist.github.com/Bauchibred/179d264df1f5828312fc8be1c7c23192/revisions.

Asides the above there are no other changes, showcasing how there is no potential H/M mitigation to be made since the files were not changed, with the current file also, per my review there is no noteworthy issue.

[c4-judge]

thereksfour marked the issue as satisfactory