LPholders can be prevented from burning their position NFTs #64
Labels
2 (Med Risk)
Assets not at direct risk, but function/availability of the protocol could be impacted or leak value
bug
Something isn't working
duplicate-21
🤖_07_group
AI based duplicate group recommendation
sufficient quality report
This report is of sufficient quality
unsatisfactory
does not satisfy C4 submission criteria; not eligible for awards
Lines of code
https://github.com/ronin-chain/katana-v3-contracts/blob/03c80179e04f40d96f06c451ea494bb18f2a58fc/src/periphery/NonfungiblePositionManager.sol#L246
https://github.com/ronin-chain/katana-v3-contracts/blob/03c80179e04f40d96f06c451ea494bb18f2a58fc/src/periphery/NonfungiblePositionManager.sol#L410
Vulnerability details
Proof of Concept
Liquidity providers can burn their position during
NonfungiblePositionManager.sol:collect()
if there's no liquidity and no tokens owedBut
increaseLiquidity
has no access control, and anyone can increase a position's liquidity by any amount, no matter how little.A malicious user in a griefing attack can continously increase liquduity by as low as 1 wei to continously dos attempt to burn a position
Recommended Mitigation Steps
Ensure only a position owner can increase his liquidity.
Assessed type
DoS
The text was updated successfully, but these errors were encountered: