Skip to content

Commit 0e339e8

Browse files
committed
Remove import/extensions rule due to low adoption of strict ESM
1 parent 2c11d48 commit 0e339e8

File tree

7 files changed

+18
-18
lines changed

7 files changed

+18
-18
lines changed

β€Ždocs/angular.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ Config for **Angular** projects.
5252
);
5353
```
5454

55-
## πŸ“ Rules (421)
55+
## πŸ“ Rules (420)
5656

57-
**345** rules are included from [`typescript` config](./typescript.md#πŸ“-rules-345). For brevity, only the **76** additional rules are listed in this document.
57+
**344** rules are included from [`typescript` config](./typescript.md#πŸ“-rules-344). For brevity, only the **76** additional rules are listed in this document.
5858

5959
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
6060

β€Ždocs/graphql.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ Config for **GraphQL servers** implemented in Node.js.
3939
export default tseslint.config(...graphql);
4040
```
4141

42-
## πŸ“ Rules (317)
42+
## πŸ“ Rules (316)
4343

44-
**294** rules are included from [`node` config](./node.md#πŸ“-rules-294). For brevity, only the **23** additional rules are listed in this document.
44+
**293** rules are included from [`node` config](./node.md#πŸ“-rules-293). For brevity, only the **23** additional rules are listed in this document.
4545

4646
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
4747

β€Ždocs/javascript.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Default config, suitable for any **JavaScript/TypeScript** project.
66

77
Refer to [setup instructions in README](../README.md#πŸ—οΈ-setup).
88

9-
## πŸ“ Rules (290)
9+
## πŸ“ Rules (289)
1010

1111
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
1212
@@ -154,7 +154,7 @@ Refer to [setup instructions in README](../README.md#πŸ—οΈ-setup).
154154
| [![sonarjs](./icons/other/sonar.png)](https://github.com/SonarSource/eslint-plugin-sonarjs#readme) | [prefer-single-boolean-return](https://github.com/SonarSource/eslint-plugin-sonarjs/blob/master/docs/rules/prefer-single-boolean-return.md)<br />Return of boolean expressions should not be wrapped into an "if-then-else" statement | | πŸ’‘ | |
155155
| [![sonarjs](./icons/other/sonar.png)](https://github.com/SonarSource/eslint-plugin-sonarjs#readme) | [prefer-while](https://github.com/SonarSource/eslint-plugin-sonarjs/blob/master/docs/rules/prefer-while.md)<br />A "while" loop should be used instead of a "for" loop | | πŸ”§ | |
156156

157-
### ⚠️ Warnings (151)
157+
### ⚠️ Warnings (150)
158158

159159
| Plugin | Rule | Options | Autofix | Overrides |
160160
| :--------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :-----: | :-------: |
@@ -191,7 +191,6 @@ Refer to [setup instructions in README](../README.md#πŸ—οΈ-setup).
191191
| [![@typescript-eslint](./icons/material/typescript.png)](https://typescript-eslint.io/) | [prefer-function-type](https://typescript-eslint.io/rules/prefer-function-type)<br />Enforce using function types instead of interfaces with call signatures | | πŸ”§ | |
192192
| [![functional](./icons/icons8/lambda.png)](https://github.com/eslint-functional/eslint-plugin-functional#readme) | [no-let](https://github.com/eslint-functional/eslint-plugin-functional/blob/v7.0.0/docs/rules/no-let.md)<br />Disallow mutable variables. | | | πŸ§ͺ🚫 |
193193
| [![functional](./icons/icons8/lambda.png)](https://github.com/eslint-functional/eslint-plugin-functional#readme) | [no-loop-statements](https://github.com/eslint-functional/eslint-plugin-functional/blob/v7.0.0/docs/rules/no-loop-statements.md)<br />Disallow imperative loops. | | | |
194-
| [![import](./icons/icons8/import.png)](https://github.com/import-js/eslint-plugin-import#readme) | [extensions](https://github.com/import-js/eslint-plugin-import/blob/v2.31.0/docs/rules/extensions.md)<br />Ensure consistent use of file extension within the import path. | <details><summary>always, ignorePackages: tru...</summary><pre lang="json"><code>[&#13; "always",&#13; {&#13; "ignorePackages": true,&#13; "checkTypeImports": true&#13; }&#13;]</code></pre></details> | | |
195194
| [![import](./icons/icons8/import.png)](https://github.com/import-js/eslint-plugin-import#readme) | [max-dependencies](https://github.com/import-js/eslint-plugin-import/blob/v2.31.0/docs/rules/max-dependencies.md)<br />Enforce the maximum number of dependencies a module can have. | <details><summary>ignoreTypeImports: true</summary><pre lang="json"><code>{&#13; "ignoreTypeImports": true&#13;}</code></pre></details> | | |
196195
| [![import](./icons/icons8/import.png)](https://github.com/import-js/eslint-plugin-import#readme) | [no-anonymous-default-export](https://github.com/import-js/eslint-plugin-import/blob/v2.31.0/docs/rules/no-anonymous-default-export.md)<br />Forbid anonymous values as default exports. | | | |
197196
| [![import](./icons/icons8/import.png)](https://github.com/import-js/eslint-plugin-import#readme) | [no-duplicates](https://github.com/import-js/eslint-plugin-import/blob/v2.31.0/docs/rules/no-duplicates.md)<br />Forbid repeated import of the same module in multiple places. | | πŸ”§ | |

β€Ždocs/ngrx.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ Config for **Angular** projects using **NgRx** library.
5252
);
5353
```
5454

55-
## πŸ“ Rules (451)
55+
## πŸ“ Rules (450)
5656

57-
**421** rules are included from [`angular` config](./angular.md#πŸ“-rules-421). For brevity, only the **30** additional rules are listed in this document.
57+
**420** rules are included from [`angular` config](./angular.md#πŸ“-rules-420). For brevity, only the **30** additional rules are listed in this document.
5858

5959
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
6060

β€Ždocs/node.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ Config for **Node.js** projects.
2020
export default tseslint.config(...node);
2121
```
2222

23-
## πŸ“ Rules (294)
23+
## πŸ“ Rules (293)
2424

25-
**290** rules are included from [`javascript` config](./javascript.md#πŸ“-rules-290). For brevity, only the **4** additional rules are listed in this document.
25+
**289** rules are included from [`javascript` config](./javascript.md#πŸ“-rules-289). For brevity, only the **4** additional rules are listed in this document.
2626

2727
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
2828

β€Ždocs/typescript.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ Config for strict **TypeScript** projects.
6565
export default tseslint.config(...typescript);
6666
```
6767

68-
## πŸ“ Rules (345)
68+
## πŸ“ Rules (344)
6969

70-
**290** rules are included from [`javascript` config](./javascript.md#πŸ“-rules-290). For brevity, only the **55** additional rules are listed in this document.
70+
**289** rules are included from [`javascript` config](./javascript.md#πŸ“-rules-289). For brevity, only the **55** additional rules are listed in this document.
7171

7272
> πŸ”§ Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>πŸ’‘ Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>πŸ§ͺ🚫 Disabled for [test files](../README.md#πŸ§ͺ-test-overrides).<br>πŸ§ͺ⚠️ Severity lessened to warning for [test files](../README.md#πŸ§ͺ-test-overrides).
7373

β€Žsrc/configs/javascript.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,12 @@ export default tseslint.config(
160160
'@typescript-eslint/no-shadow': 'warn',
161161

162162
// https://github.com/import-js/eslint-plugin-import#rules
163-
'import/extensions': [
164-
'warn',
165-
'always',
166-
{ ignorePackages: true, checkTypeImports: true },
167-
],
163+
// probably too strict due to low adoption of strict ESM
164+
// 'import/extensions': [
165+
// 'warn',
166+
// 'always',
167+
// { ignorePackages: true, checkTypeImports: true },
168+
// ],
168169
'import/max-dependencies': ['warn', { ignoreTypeImports: true }],
169170
'import/no-absolute-path': 'error',
170171
'import/no-amd': 'error',

0 commit comments

Comments
Β (0)