Feature/user management #8
Conversation
web/src/routing/routes/UsersAdministration/Users/UsersTable/UsersTable.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/GroupsTable/GroupsTable.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Users/UsersTable/UsersTable.tsx
Outdated
Show resolved
Hide resolved
web/src/layouts/UsersAdministrationLayout/UsersAdministrationLayout.tsx
Outdated
Show resolved
Hide resolved
| <PageLayout | ||
| py={5} | ||
| px={2} | ||
| mt={0} |
There was a problem hiding this comment.
Is there a need to declare mt={0}. Shouldn't PageLayout have 0 ootb, so parent components are able to align it without problems?
There was a problem hiding this comment.
I had to because <PageLayout /> has margin-top set to 32px by default. And I didn't wanted it in my case.
web/src/routing/routes/UsersAdministration/Groups/GroupDetails/GroupDetails.tsx
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/GroupDetails/GroupDetails.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/GroupDetails/GroupDetails.tsx
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/GroupDetails/GroupDetails.tsx
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/GroupDetails/GroupDetails.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/Modals/AddToGroupModal/AddToGroupModal.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Groups/Modals/AddToGroupModal/AddToGroupModal.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Users/UserDetails/UserDetails.tsx
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Users/UserDetails/UserDetails.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Users/UserDetails/UserDetails.tsx
Outdated
Show resolved
Hide resolved
web/src/routing/routes/UsersAdministration/Users/UsersTable/UsersTable.tsx
Outdated
Show resolved
Hide resolved
| color: rgbaColors.grey.main, | ||
| border: `1px solid ${rgbaColors.grey.lighter}`, | ||
| background: "none", | ||
| py: 1.125, |
There was a problem hiding this comment.
Why is it different Y-padding for disabled button? Text inside might flicker when button will change from active to disabled
There was a problem hiding this comment.
The reason is that disabled button gets 1px border on top and bottom. And to stay with the same height as on not disabled button I need to subtract this extra 2px added from border by making smaller padding.
| }} | ||
| icon={false} | ||
| > | ||
| Something went wrong. Please try again. |
There was a problem hiding this comment.
text inside Alert shouldn't be hardcoded + it's looks like onClose calls 2 time (first in Snackbar props and second in Alert props)
There was a problem hiding this comment.
The thing is that as the most external and main component of this popup needs it for example to close it when we click outside this element. And as different component I putted inside gives me ‘X’ icon only when I pass onClose prop which is also saying what it should do onClose.
| const IndexPage = lazy(() => import("./routes/Index/IndexPage")); | ||
| const SignIn = lazy(() => import("./routes/SignIn/SignIn")); | ||
| const SignUp = lazy(() => import("./routes/SignUp/SignUp")); | ||
| const VerifyEmail = lazy(() => import("./routes/VerifyEmail/VerifyEmail")); | ||
| const Users = lazy(() => import("./routes/UsersAdministration/Users/Users")); | ||
| const UserDetails = lazy(() => | ||
| import("./routes/UsersAdministration/Users/UserDetails/UserDetails") | ||
| ); | ||
| const Groups = lazy(() => import("./routes/UsersAdministration/Groups/Groups")); | ||
| const GroupDetails = lazy(() => | ||
| import("./routes/UsersAdministration/Groups/GroupDetails/GroupDetails") | ||
| ); |
There was a problem hiding this comment.
Can we make this alphabetical order?
Create views for Users Administration.
Added:
-Users, Groups, User's Details and Group's details views based on routes.;
-Upgrade react-router-dom from 5.3.0 to 6.3.0.;
-Modals and error notification;
Need to be added:
FE:
-getting and handling data from backend, tests;
BE:
-search;
-returning data for tables;
-endpoints;