Revert "⚡️ Speed up VectorDBQA.validate_search_type() by 7% in libs/langchain/langchain/chains/retrieval_qa/base.py"

Author: aphexcx

libs/langchain/langchain/chains/retrieval_qa/base.py

@@ -1,5 +1,4 @@
 """Chain for question-answering against a vector database."""
-
 from __future__ import annotations
 
 import inspect
@@ -263,11 +262,10 @@ def raise_deprecation(cls, values: Dict) -> Dict:
     @root_validator()
     def validate_search_type(cls, values: Dict) -> Dict:
         """Validate search type."""
-        if "search_type" in values and values["search_type"] not in (
-            "similarity",
-            "mmr",
-        ):
-            raise ValueError(f"search_type of {values['search_type']} not allowed.")
+        if "search_type" in values:
+            search_type = values["search_type"]
+            if search_type not in ("similarity", "mmr"):
+                raise ValueError(f"search_type of {search_type} not allowed.")
         return values
 
     def _get_docs(