This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Refactor duplicated code for removing saved resource #349
Assignees
Labels
discussion needed
⚠️ This issue needs to be discussed further before we can begin work on it
low priority
An issue that is nice to have but does not impact usability or necessary functionality
Comments
acharliekelly
added
the
low priority
acharliekelly
added
the
discussion needed
|
Currently, the "action" of saving or removing a resource is being dispatched, but the , but then actually reading/re-writing the query string is handled in the component. Seems like this isn't how Redux is supposed to work, but I don't really know it that well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Fixed issue #329 by copying the removalConfirmed function from SavedResource to OrganizationCard. To avoid redundancy, this should be moved to a new location where it can be called by both components. Would have included this in #329, but didn't know where to put it. Also, wanted to wait for issue #335 to be closed, since it uses a lot of the same code and I despise merge conflicts.
The text was updated successfully, but these errors were encountered: