Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if we need to flatten out data in the VueX Store #3

Open
zmon opened this issue Jul 6, 2019 · 2 comments
Open

Determine if we need to flatten out data in the VueX Store #3

zmon opened this issue Jul 6, 2019 · 2 comments
Labels
question Further information is requested SPA

Comments

@zmon
Copy link
Member

zmon commented Jul 6, 2019

Background:

In the past, there were issues with the reactivity of the convictions and possibly charges. This was caused them being nested in inside of client.
This was solved by two things

  1. Moving convictions to the root of the VueX store
  2. Using Vue's set()

Questions:

  1. Should we move charges to the root of the VueX store?
  2. Is the current code updating the DOM correctly?
  3. What code pattern should we be using?
@zmon zmon added the question Further information is requested label Jul 6, 2019
@zmon
Copy link
Member Author

zmon commented Jul 6, 2019

@zmon
Copy link
Member Author

zmon commented Jul 17, 2019

@zmon zmon added the SPA label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested SPA
Projects
None yet
Development

No branches or pull requests

1 participant