apply code suggestions

Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>

Author: michalsn

app/Config/WorkerMode.php

@@ -41,10 +41,10 @@ class WorkerMode
     ];
 
     /**
-     * Garbage Collection
+     * Force Garbage Collection
      *
      * Whether to force garbage collection after each request.
      * Helps prevent memory leaks at a small performance cost.
      */
-    public bool $garbageCollection = true;
+    public bool $forceGarbageCollection = true;
 }

system/Cache/Handlers/PredisHandler.php

@@ -224,7 +224,7 @@ public function reconnect(): bool
     {
         try {
             $this->redis->disconnect();
-        } catch (Exception $e) {
+        } catch (Exception) {
             // Connection already dead, that's fine
         }
 

system/Commands/Worker/Views/frankenphp-worker.php.tpl

@@ -69,11 +69,11 @@ $workerConfig = config('WorkerMode');
  */
 
 $handler = static function () use ($app, $workerConfig) {
-    // Validate database connections before handling request
-    DatabaseConfig::validateForWorkerMode();
+    // Reconnect database connections before handling request
+    DatabaseConfig::reconnectForWorkerMode();
 
-    // Validate cache connection before handling request
-    Services::validateForWorkerMode();
+    // Reconnect cache connection before handling request
+    Services::reconnectCacheForWorkerMode();
 
     // Reset request-specific state
     $app->resetForWorkerMode();
@@ -93,7 +93,7 @@ $handler = static function () use ($app, $workerConfig) {
         Services::exceptions()->exceptionHandler($e);
     }
 
-    if ($workerConfig->garbageCollection) {
+    if ($workerConfig->forceGarbageCollection) {
         // Force garbage collection
         gc_collect_cycles();
     }

system/Config/BaseService.php

@@ -375,13 +375,13 @@ public static function reset(bool $initAutoloader = true)
     }
 
     /**
-     * Validate cache connections for worker mode at the start of a request.
+     * Reconnect cache connection for worker mode at the start of a request.
      * Checks if cache connection is alive and reconnects if needed.
      *
      * This should be called at the beginning of each request in worker mode,
      * before the application runs.
      */
-    public static function validateForWorkerMode(): void
+    public static function reconnectCacheForWorkerMode(): void
     {
         if (! isset(static::$instances['cache'])) {
             return;

system/Database/Config.php

@@ -154,13 +154,12 @@ protected static function ensureFactory()
     }
 
     /**
-     * Validate database connections for worker mode at the start of a request.
-     * Checks if connections are alive and reconnects if needed.
+     * Reconnect database connections for worker mode at the start of a request.
      *
      * This should be called at the beginning of each request in worker mode,
      * before the application runs.
      */
-    public static function validateForWorkerMode(): void
+    public static function reconnectForWorkerMode(): void
     {
         if (static::$instances === []) {
             return;

tests/system/Commands/WorkerCommandsTest.php

@@ -163,7 +163,7 @@ public function testWorkerInstallCreatesValidPHPFile(): void
         $this->assertStringStartsWith('<?php', $content);
 
         $this->assertStringContainsString('frankenphp_handle_request', (string) $content);
-        $this->assertStringContainsString('DatabaseConfig::validateForWorkerMode', (string) $content);
+        $this->assertStringContainsString('DatabaseConfig::reconnectForWorkerMode', (string) $content);
         $this->assertStringContainsString('DatabaseConfig::cleanupForWorkerMode', (string) $content);
     }
 

tests/system/CommonSingleServiceTest.php

@@ -96,7 +96,7 @@ public static function provideServiceNames(): iterable
             'has',
             'encrypter', // Encrypter needs a starter key
             'session', // Headers already sent
-            'validateForWorkerMode',
+            'reconnectCacheForWorkerMode',
         ];
 
         if ($services === []) {

tests/system/Config/ServicesTest.php

@@ -540,24 +540,24 @@ public function testResetForWorkerMode(): void
 
     #[PreserveGlobalState(false)]
     #[RunInSeparateProcess]
-    public function testValidateForWorkerMode(): void
+    public function testReconnectCacheForWorkerMode(): void
     {
         Services::cache();
         $this->assertTrue(Services::has('cache'));
 
-        Services::validateForWorkerMode();
+        Services::reconnectCacheForWorkerMode();
 
         $this->assertTrue(Services::has('cache'));
     }
 
     #[PreserveGlobalState(false)]
     #[RunInSeparateProcess]
-    public function testValidateForWorkerModeWithNoCache(): void
+    public function testReconnectCacheForWorkerModeWithNoCache(): void
     {
         Services::resetSingle('cache');
         $this->assertFalse(Services::has('cache'));
 
-        Services::validateForWorkerMode();
+        Services::reconnectCacheForWorkerMode();
 
         $this->assertFalse(Services::has('cache'));
     }

tests/system/Database/Live/WorkerModeTest.php

@@ -48,13 +48,13 @@ public function testCleanupForWorkerMode(): void
         $this->assertNotFalse($this->getPrivateProperty($conn, 'connID'));
     }
 
-    public function testValidateForWorkerMode(): void
+    public function testReconnectForWorkerMode(): void
     {
         $conn = Config::connect();
         $this->assertInstanceOf(BaseConnection::class, $conn);
         $this->assertNotFalse($this->getPrivateProperty($conn, 'connID'));
 
-        Config::validateForWorkerMode();
+        Config::reconnectForWorkerMode();
 
         $this->assertNotFalse($this->getPrivateProperty($conn, 'connID'));
     }

user_guide_src/source/changelogs/v4.7.0.rst

@@ -337,11 +337,11 @@ Changes
 - **CodeIgniter:** Added ``CodeIgniter::resetForWorkerMode()`` method to reset request-specific state between worker requests.
 - **Config:** Added ``app/Config/WorkerMode.php`` for worker mode configuration (persistent services, garbage collection).
 - **Cookie:** The ``CookieInterface::EXPIRES_FORMAT`` has been changed to ``D, d M Y H:i:s T`` to follow the recommended format in RFC 7231.
-- **DatabaseConfig:** Added ``Config::validateForWorkerMode()`` and ``Config::cleanupForWorkerMode()`` methods for database connection management in worker mode.
+- **DatabaseConfig:** Added ``Config::reconnectForWorkerMode()`` and ``Config::cleanupForWorkerMode()`` methods for database connection management in worker mode.
 - **Events:** Added ``Events::cleanupForWorkerMode()`` method.
 - **Format:** Added support for configuring ``json_encode()`` maximum depth via ``Config\Format::$jsonEncodeDepth``.
 - **Paths:** Added support for changing the location of the ``.env`` file via the ``Paths::$envDirectory`` property.
-- **Services:** Added ``Services::resetForWorkerMode()`` and ``Services::validateForWorkerMode()`` methods.
+- **Services:** Added ``Services::resetForWorkerMode()`` and ``Services::reconnectCacheForWorkerMode()`` methods.
 - **Toolbar:** Added ``$disableOnHeaders`` property to **app/Config/Toolbar.php**.
 - **Toolbar:** Added ``Toolbar::reset()`` method to reset debug toolbar collectors.