From 66d00ee7f0395825d39b720b373e81724e67ef99 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 25 Aug 2025 23:38:32 +0700 Subject: [PATCH 1/3] refactor: apply rector latest dev-main --- .../Routes/AutoRouterImproved/AutoRouteCollector.php | 2 +- tests/system/Database/Live/OCI8/CallStoredProcedureTest.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php b/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php index f4a5204fb49b..88974066c755 100644 --- a/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php +++ b/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php @@ -99,7 +99,7 @@ public function get(): array * * @return list> */ - private function addFilters($routes) + private function addFilters(array $routes) { $filterCollector = new FilterCollector(true); diff --git a/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php b/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php index 43816b7301b3..824fc6a3ee3e 100644 --- a/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php +++ b/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php @@ -55,7 +55,7 @@ public function testCallPackageProcedure(): void ], ]); - $this->assertSame('7', $result); + $this->assertSame(7, $result); } public function testCallStoredProcedure(): void @@ -77,7 +77,7 @@ public function testCallStoredProcedure(): void ], ]); - $this->assertSame('7', $result); + $this->assertSame(7, $result); } public function testCallStoredProcedureForCursor(): void From 6967b4c2e6e5b4436ae76948ca10e38b5143550f Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 25 Aug 2025 23:51:44 +0700 Subject: [PATCH 2/3] refactor: fix unit test init result on call stored procedure result --- .../system/Database/Live/OCI8/CallStoredProcedureTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php b/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php index 824fc6a3ee3e..32c9efbf0624 100644 --- a/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php +++ b/tests/system/Database/Live/OCI8/CallStoredProcedureTest.php @@ -38,7 +38,7 @@ protected function setUp(): void public function testCallPackageProcedure(): void { - $result = 0; + $result = '0'; $this->db->storedProcedure('calculator.plus', [ [ @@ -55,12 +55,12 @@ public function testCallPackageProcedure(): void ], ]); - $this->assertSame(7, $result); + $this->assertSame('7', $result); } public function testCallStoredProcedure(): void { - $result = 0; + $result = '0'; $this->db->storedProcedure('plus', [ [ @@ -77,7 +77,7 @@ public function testCallStoredProcedure(): void ], ]); - $this->assertSame(7, $result); + $this->assertSame('7', $result); } public function testCallStoredProcedureForCursor(): void From 7f2251e4d0e5e490a98bda306544d938ad9ea701 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 25 Aug 2025 23:53:07 +0700 Subject: [PATCH 3/3] refactor: add array return on addFilters() method --- .../Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php b/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php index 88974066c755..d29f6a9b7049 100644 --- a/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php +++ b/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php @@ -99,7 +99,7 @@ public function get(): array * * @return list> */ - private function addFilters(array $routes) + private function addFilters(array $routes): array { $filterCollector = new FilterCollector(true);