-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update your utility #1
Comments
Are you offering to help? |
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Updates the code to use PSR-2 formatting (https://www.php-fig.org/psr/psr-2/). This requires some changes to formatting of class and method names. * Adds composer to the project. Currently only pulls in `phpunit` as a development requirement. * Adds `phpunit` tests created from the `example.php` code along with testing the various exceptions that can be thrown. * Some code polish based on static analysis.
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Rename class to `Search`, search method to `execute`, and push file into `src` directory. Give it a nice namespace to live in. * Update benchmark, example, and documentation to show namespace usage. * Add PSR-4 namespace autoload to composer.
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Move benchmarking functionality into its own class.
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Removing example PSR-4 path from composer
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Update documentation for installation via composer
sprak3000
pushed a commit
to sprak3000/ahocorasickphp
that referenced
this issue
Oct 1, 2018
* Update documentation for installation via composer
Whoever wants something modern, there is https://github.com/wikimedia/AhoCorasick and https://github.com/tianhe1986/FatAhoCorasick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
update your utility, follow the PSR, for tests use PHPunit and also connect Composer
The text was updated successfully, but these errors were encountered: