From db9e1ea566813606ca055868be13f6ff4a760ab8 Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Tue, 25 Mar 2025 16:12:55 +0000 Subject: [PATCH] Remove unnecessary virtual specifiers Clang has added a new warning for virtual specifiers on methods of `final` classes. This cleans them up in preparation for enabling that warning. Bug: chromium:403236787 Change-Id: I1bb144494028f674d0de409a65412af1f084b56c Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6391658 Commit-Queue: Mark Foltz Reviewed-by: Mark Foltz --- osp/public/service_listener.h | 2 +- osp/public/service_publisher.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osp/public/service_listener.h b/osp/public/service_listener.h index 3407ce9c..9dbe1b26 100644 --- a/osp/public/service_listener.h +++ b/osp/public/service_listener.h @@ -96,7 +96,7 @@ class ServiceListener final { ServiceListener& operator=(const ServiceListener&) = delete; ServiceListener(ServiceListener&&) noexcept = delete; ServiceListener& operator=(ServiceListener&&) noexcept = delete; - virtual ~ServiceListener(); + ~ServiceListener(); // Sets the service configuration for this listener. void SetConfig(const Config& config); diff --git a/osp/public/service_publisher.h b/osp/public/service_publisher.h index d231e2a8..fdadc8a1 100644 --- a/osp/public/service_publisher.h +++ b/osp/public/service_publisher.h @@ -103,7 +103,7 @@ class ServicePublisher final { ServicePublisher& operator=(const ServicePublisher&) = delete; ServicePublisher(ServicePublisher&&) noexcept = delete; ServicePublisher& operator=(ServicePublisher&&) noexcept = delete; - virtual ~ServicePublisher(); + ~ServicePublisher(); // Sets the service configuration for this publisher. void SetConfig(const Config& config);