Address CodeRabbit review: set -e safety, docs accuracy, test isolation

- Make cache write best-effort in cmd_init (print output first, guard
  mkdir/write with || true) so set -e failures don't swallow shell init
- Add || true guards to eval/source in README and help.sh setup examples
  to protect users with set -e in their shell rc
- Fix misleading "auto-invalidates on update" wording in help text — the
  cached setup pattern only regenerates when the cache file is missing
- Simplify cache tests to use setup()'s XDG_CACHE_HOME instead of a
  shared per-PID cache_dir that can leak between tests on failure

Author: helizaga

README.md

@@ -216,13 +216,13 @@ cd "$(git gtr go 1)"             # Navigate to main repo
 ```bash
 # Bash (add to ~/.bashrc)
 _gtr_init="${XDG_CACHE_HOME:-$HOME/.cache}/gtr/init-gtr.bash"
-[[ -f "$_gtr_init" ]] || eval "$(git gtr init bash)"
-source "$_gtr_init" 2>/dev/null; unset _gtr_init
+[[ -f "$_gtr_init" ]] || eval "$(git gtr init bash)" || true
+source "$_gtr_init" 2>/dev/null || true; unset _gtr_init
 
 # Zsh (add to ~/.zshrc)
 _gtr_init="${XDG_CACHE_HOME:-$HOME/.cache}/gtr/init-gtr.zsh"
-[[ -f "$_gtr_init" ]] || eval "$(git gtr init zsh)"
-source "$_gtr_init" 2>/dev/null; unset _gtr_init
+[[ -f "$_gtr_init" ]] || eval "$(git gtr init zsh)" || true
+source "$_gtr_init" 2>/dev/null || true; unset _gtr_init
 
 # Fish (add to ~/.config/fish/config.fish)
 git gtr init fish | source
@@ -233,7 +233,7 @@ gtr cd my-feature
 gtr cd 1
 ```
 
-The cache auto-regenerates on first run and auto-invalidates when git-gtr is updated. To force-regenerate: `rm -rf ~/.cache/gtr`
+The cache generates on first run and refreshes the next time `git gtr init <shell>` runs. To force-regenerate: `rm -rf ~/.cache/gtr`
 
 With [fzf](https://github.com/junegunn/fzf) installed, `gtr cd` (no arguments) opens a command palette with git log preview and keybindings: `ctrl-e` editor, `ctrl-a` AI, `ctrl-d` delete, `ctrl-y` copy, `ctrl-r` refresh.
 

lib/commands/help.sh

@@ -347,8 +347,9 @@ Generates shell functions for enhanced features like 'gtr cd <branch>'
 which changes directory to a worktree. Add to your shell configuration.
 
 Output is cached to ~/.cache/gtr/ for fast shell startup (~1ms vs ~60ms).
-The cache auto-invalidates when git-gtr is updated. To force-regenerate:
-  rm -rf ~/.cache/gtr
+The cache refreshes the next time 'git gtr init <shell>' runs (checks version).
+With the recommended setup below, it regenerates when the cache file is missing.
+To force-regenerate: rm -rf ~/.cache/gtr
 
 Supported shells: bash, zsh, fish
 
@@ -359,13 +360,13 @@ Options:
 Setup (sources cached output directly for fast startup):
   # Bash (add to ~/.bashrc)
   _gtr_init="${XDG_CACHE_HOME:-$HOME/.cache}/gtr/init-gtr.bash"
-  [[ -f "$_gtr_init" ]] || eval "$(git gtr init bash)"
-  source "$_gtr_init" 2>/dev/null; unset _gtr_init
+  [[ -f "$_gtr_init" ]] || eval "$(git gtr init bash)" || true
+  source "$_gtr_init" 2>/dev/null || true; unset _gtr_init
 
   # Zsh (add to ~/.zshrc)
   _gtr_init="${XDG_CACHE_HOME:-$HOME/.cache}/gtr/init-gtr.zsh"
-  [[ -f "$_gtr_init" ]] || eval "$(git gtr init zsh)"
-  source "$_gtr_init" 2>/dev/null; unset _gtr_init
+  [[ -f "$_gtr_init" ]] || eval "$(git gtr init zsh)" || true
+  source "$_gtr_init" 2>/dev/null || true; unset _gtr_init
 
   # Fish (add to ~/.config/fish/config.fish)
   git gtr init fish | source

lib/commands/init.sh

@@ -80,12 +80,13 @@ cmd_init() {
     fi
   fi
 
-  # Generate, cache, and output
+  # Generate, output, and cache (output first so set -e cache failures don't swallow it)
   local output
   output="$("$generator" | sed "s/__FUNC__/$func_name/g")"
-  mkdir -p "$cache_dir"
-  printf '%s\n%s\n' "$cache_stamp" "$output" > "$cache_file"
   printf '%s\n' "$output"
+  if mkdir -p "$cache_dir" 2>/dev/null; then
+    printf '%s\n%s\n' "$cache_stamp" "$output" > "$cache_file" 2>/dev/null || true
+  fi
 }
 
 _init_bash() {

tests/init.bats

@@ -507,59 +507,49 @@ teardown() {
 # ── caching (default behavior) ──────────────────────────────────────────────
 
 @test "init creates cache file and returns output" {
-  local cache_dir="$BATS_TMPDIR/gtr-cache-test-$$"
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="9.9.9" run cmd_init zsh
+  GTR_VERSION="9.9.9" run cmd_init zsh
   [ "$status" -eq 0 ]
   [[ "$output" == *"gtr()"* ]]
-  [ -f "$cache_dir/gtr/init-gtr.zsh" ]
-  rm -rf "$cache_dir"
+  [ -f "$XDG_CACHE_HOME/gtr/init-gtr.zsh" ]
 }
 
 @test "init returns cached output on second call" {
-  local cache_dir="$BATS_TMPDIR/gtr-cache-test-$$"
   # First call: generates and caches
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="9.9.9" run cmd_init bash
+  GTR_VERSION="9.9.9" run cmd_init bash
   [ "$status" -eq 0 ]
   local first_output="$output"
   # Second call: reads from cache
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="9.9.9" run cmd_init bash
+  GTR_VERSION="9.9.9" run cmd_init bash
   [ "$status" -eq 0 ]
   [ "$output" = "$first_output" ]
-  rm -rf "$cache_dir"
 }
 
 @test "cache invalidates when version changes" {
-  local cache_dir="$BATS_TMPDIR/gtr-cache-test-$$"
   # Generate with version 1.0.0
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="1.0.0" run cmd_init zsh
+  GTR_VERSION="1.0.0" run cmd_init zsh
   [ "$status" -eq 0 ]
   # Check cache stamp
   local stamp
-  stamp="$(head -1 "$cache_dir/gtr/init-gtr.zsh")"
+  stamp="$(head -1 "$XDG_CACHE_HOME/gtr/init-gtr.zsh")"
   [[ "$stamp" == *"version=1.0.0"* ]]
   # Regenerate with version 2.0.0
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="2.0.0" run cmd_init zsh
+  GTR_VERSION="2.0.0" run cmd_init zsh
   [ "$status" -eq 0 ]
-  stamp="$(head -1 "$cache_dir/gtr/init-gtr.zsh")"
+  stamp="$(head -1 "$XDG_CACHE_HOME/gtr/init-gtr.zsh")"
   [[ "$stamp" == *"version=2.0.0"* ]]
-  rm -rf "$cache_dir"
 }
 
 @test "cache uses --as func name in cache key" {
-  local cache_dir="$BATS_TMPDIR/gtr-cache-test-$$"
-  XDG_CACHE_HOME="$cache_dir" GTR_VERSION="9.9.9" run cmd_init bash --as myfn
+  GTR_VERSION="9.9.9" run cmd_init bash --as myfn
   [ "$status" -eq 0 ]
   [[ "$output" == *"myfn()"* ]]
-  [ -f "$cache_dir/gtr/init-myfn.bash" ]
-  rm -rf "$cache_dir"
+  [ -f "$XDG_CACHE_HOME/gtr/init-myfn.bash" ]
 }
 
 @test "cache works for all shells" {
-  local cache_dir="$BATS_TMPDIR/gtr-cache-test-$$"
   for sh in bash zsh fish; do
-    XDG_CACHE_HOME="$cache_dir" GTR_VERSION="9.9.9" run cmd_init "$sh"
+    GTR_VERSION="9.9.9" run cmd_init "$sh"
     [ "$status" -eq 0 ]
-    [ -f "$cache_dir/gtr/init-gtr.${sh}" ]
+    [ -f "$XDG_CACHE_HOME/gtr/init-gtr.${sh}" ]
   done
-  rm -rf "$cache_dir"
 }