Skip to content

Commit 7b1ab9d

Browse files
committed
Fix double workflow DB fetch
1 parent ce514b2 commit 7b1ab9d

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

joeflow/views.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ def get_task(self):
5858

5959
def next_task(self):
6060
task = self.get_task()
61-
task.workflow = self.model._base_manager.get(
62-
pk=self.model._base_manager.get(pk=self.object.pk)
63-
)
61+
task.workflow = self.model._base_manager.get(pk=self.object.pk)
6462
task.finish(self.request.user)
6563
task.start_next_tasks()
6664

tests/tasks/test_human.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import pytest
2+
3+
from tests.testapp import workflows
4+
5+
6+
class TestStartView:
7+
def test_get(self, client):
8+
response = client.get("/simple/start_view/custom/postfix/")
9+
assert response.status_code == 200
10+
11+
@pytest.mark.django_db
12+
def test_post(self, client):
13+
assert not workflows.SimpleWorkflow.objects.exists()
14+
response = client.post("/simple/start_view/custom/postfix/")
15+
assert response.status_code == 302
16+
assert response["Location"] == "/simple/1/"
17+
assert workflows.SimpleWorkflow.objects.exists()

0 commit comments

Comments
 (0)