Skip to content

Commit 3ef1688

Browse files
authored
fix!: proto fields renames (#129)
* fix!: proto fields renames - 여러 개체를 나타낼떼는 복수형(`papers`)을 씁니다. - 줄임말(`pub_date`)을 함부로 쓰면 가독성 떨어집니다. * chore: update database * fix: test (pub_date -> published_date) * chore: update database * chore: update database * chore: update database * chore: update database * chore: code formatter * chore: update database
1 parent 5112faf commit 3ef1688

File tree

17 files changed

+17127
-17122
lines changed

17 files changed

+17127
-17122
lines changed

client/lib/protos/pkg/pr12er/database.pb.dart

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/lib/protos/pkg/pr12er/database.pbjson.dart

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/lib/protos/pkg/pr12er/messages.pb.dart

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/lib/protos/pkg/pr12er/messages.pbjson.dart

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/lib/screens/detail_screen.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ class DetailScreen extends StatelessWidget {
6868

6969
return Column(children: [
7070
PaperAbstractWidget(
71-
paper: snapshot.data!.paper[0]),
71+
paper: snapshot.data!.papers[0]),
7272
const SizedBox(height: 15),
7373
RecommentationWidget(detail: snapshot.data!),
7474
const SizedBox(height: 15),
7575
RepositoryWidget(
7676
repositories:
77-
snapshot.data!.paper[0].repositories,
77+
snapshot.data!.papers[0].repositories,
7878
)
7979
]);
8080
},
@@ -98,15 +98,15 @@ class DetailScreen extends StatelessWidget {
9898

9999
if (detail != null) {
100100
message.writeln('\nPaper');
101-
message.writeln('\t- title: ${detail!.paper[0].title}');
101+
message.writeln('\t- title: ${detail!.papers[0].title}');
102102
message.writeln(
103-
'\t- link: https://arxiv.org/abs/${detail!.paper[0].arxivId}');
103+
'\t- link: https://arxiv.org/abs/${detail!.papers[0].arxivId}');
104104

105105
message.writeln('abstract');
106-
message.writeln('\t- ${detail!.paper[0].abstract}');
106+
message.writeln('\t- ${detail!.papers[0].abstract}');
107107

108108
message.writeln('repositories');
109-
for (final repo in detail!.paper[0].repositories) {
109+
for (final repo in detail!.papers[0].repositories) {
110110
message.writeln('\t- ${repo.owner}: ${repo.url}');
111111
}
112112

client/lib/widgets/detail/recommendataion.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class RecommentationWidget extends StatelessWidget {
3838
child: ListTile(
3939
title: Text(paper.title),
4040
subtitle: Text(
41-
"${paper.authors[0]} | ${DateFormat.yMd().format(paper.pubDate.toDateTime())}")));
41+
"${paper.authors[0]} | ${DateFormat.yMd().format(paper.publishedDate.toDateTime())}")));
4242
}
4343

4444
List<Paper> getReferencePapers(Detail detail) {

metadata-manager/cmd/genmapping.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ var genmappingCmd = &cobra.Command{
6565

6666
table.Rows = append(table.Rows, &pr12er.MappingTableRow{
6767
PrId: prID,
68-
PaperArxivId: paperIDs,
68+
PaperArxivIds: paperIDs,
6969
YoutubeVideoId: item.ContentDetails.VideoId,
7070
})
7171
}

metadata-manager/internal/fetcher/fetcher.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ func (f *Fetcher) fetchArxivPapersInfo(paperArxivIDs []string) ([]*pr12er.Paper,
5454
methods := transform.Methods(methodList.Results)
5555

5656
pr12erPapers = append(pr12erPapers, &pr12er.Paper{
57-
PaperId: paperID,
58-
Title: paper.Title,
59-
ArxivId: arxivID,
60-
Abstract: lineEndingRegexp.ReplaceAllString(paper.Abstract, " "),
61-
PubDate: timestamppb.New(time.Time(paper.Published)),
62-
Authors: paper.Authors,
63-
Repositories: repositories,
64-
Methods: methods,
57+
PaperId: paperID,
58+
Title: paper.Title,
59+
ArxivId: arxivID,
60+
Abstract: lineEndingRegexp.ReplaceAllString(paper.Abstract, " "),
61+
PublishedDate: timestamppb.New(time.Time(papers.Results[0].Published)),
62+
Authors: paper.Authors,
63+
Repositories: repositories,
64+
Methods: methods,
6565
})
6666
}
6767
}
@@ -151,7 +151,7 @@ func handleResponse(resp *youtube.VideoListResponse) ([]*pr12er.YouTubeVideo, er
151151

152152
// FetchOnlyPapers fetches papers without video information.
153153
func (f *Fetcher) FetchOnlyPapers(prRow *pr12er.MappingTableRow) (*pr12er.PrVideo, error) {
154-
papers, err := f.fetchArxivPapersInfo(prRow.PaperArxivId)
154+
papers, err := f.fetchArxivPapersInfo(prRow.PaperArxivIds)
155155
if err != nil {
156156
return nil, err
157157
}

0 commit comments

Comments
 (0)