From 432cbad408873c5ab5180590ede22b8e2b71dfb5 Mon Sep 17 00:00:00 2001 From: JohnAllenTech <46611809+JohnAllenTech@users.noreply.github.com> Date: Sat, 19 Oct 2024 14:44:20 -0600 Subject: [PATCH 1/2] fix: bookmark icon should be visible for unauthenticated user --- e2e/articles.spec.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/e2e/articles.spec.ts b/e2e/articles.spec.ts index 48361487..ccf58ae7 100644 --- a/e2e/articles.spec.ts +++ b/e2e/articles.spec.ts @@ -16,7 +16,7 @@ test.describe("Unauthenticated Articles Page", () => { ); }); - test("Should not show bookmark article icon", async ({ page }) => { + test("Should show bookmark article icon", async ({ page }) => { await page.goto("http://localhost:3000/articles"); await expect( @@ -25,7 +25,7 @@ test.describe("Unauthenticated Articles Page", () => { await expect( page.locator("article").first().getByLabel("Bookmark this post"), - ).toBeHidden(); + ).toBeVisible(); }); test("Should load more articles when scrolling to the end of the page", async ({ page, @@ -164,6 +164,12 @@ test.describe("Authenticated Articles Page", () => { await expect(page.getByRole("button", { name: "Next" })).toBeVisible(); await page.getByRole("button", { name: "Next" }).click(); + + await page.route("**/*", async (route) => { + await new Promise((f) => setTimeout(f, 500)); + await route.continue(); + }); + await expect( page.getByRole("button", { name: "Publish now" }), ).toBeVisible(); From dbfce088f0d52c40639a811bad39092e9e0ce5f2 Mon Sep 17 00:00:00 2001 From: JohnAllenTech <46611809+JohnAllenTech@users.noreply.github.com> Date: Sat, 19 Oct 2024 14:45:39 -0600 Subject: [PATCH 2/2] chore: removing route slow down left in my accident --- e2e/articles.spec.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/e2e/articles.spec.ts b/e2e/articles.spec.ts index ccf58ae7..fca5ab75 100644 --- a/e2e/articles.spec.ts +++ b/e2e/articles.spec.ts @@ -165,11 +165,6 @@ test.describe("Authenticated Articles Page", () => { await expect(page.getByRole("button", { name: "Next" })).toBeVisible(); await page.getByRole("button", { name: "Next" }).click(); - await page.route("**/*", async (route) => { - await new Promise((f) => setTimeout(f, 500)); - await route.continue(); - }); - await expect( page.getByRole("button", { name: "Publish now" }), ).toBeVisible();