Postop refactor #12
Merged
Postop refactor #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenoliss
reviewed
Mar 14, 2024
src/MagicSpend.sol
Outdated
Comment on lines
147
to
149
| // `PostOpMode.postOpReverted` should be impossible. | ||
| // Only possible cause would be if this contract does not enough ETH to transfer | ||
| // but this is checked at the validation step. |
There was a problem hiding this comment.
Suggested change
| // `PostOpMode.postOpReverted` should be impossible. | |
| // Only possible cause would be if this contract does not enough ETH to transfer | |
| // but this is checked at the validation step. | |
| // `PostOpMode.postOpReverted` should be impossible. | |
| // Only possible cause would be if this contract does not own enough ETH to transfer | |
| // but this is checked at the validation step. |
src/MagicSpend.sol
Outdated
| @@ -212,7 +227,7 @@ contract MagicSpend is Ownable, IPaymaster { | |||
| /// | |||
| /// @dev Reverts if not called by the owner of the contract. | |||
| /// | |||
| /// @param amount The amount to stake in the Entrypoint. | |||
| /// @param amount The amount to stake in the Entrypoint. | |||
| /// @param unstakeDelaySeconds XXX | |||
There was a problem hiding this comment.
Suggested change
| /// @param unstakeDelaySeconds XXX | |
| /// @param unstakeDelaySeconds The new lock duration before the deposit can be withdrawn. |
wilsoncusack
commented
Mar 14, 2024
| @@ -40,28 +40,6 @@ contract ValidatePaymasterUserOpTest is PaymasterMagicSpendBaseTest, ValidateTes | |||
| assertEq(uint160(validationData), 1); | |||
| } | |||
|
|
|||
| function test_setsExcess(uint256 amount_, uint256 maxCost_, uint256 actualCost) public { | |||
There was a problem hiding this comment.
these are no longer needed as there should be no way for excess to be non 0 at end of userOp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening back up #10 re eth-infinitism/account-abstraction#460