Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option retry_policy is dismissed on start_workflow. #276

Open
iegomez opened this issue Nov 30, 2023 · 1 comment
Open

Option retry_policy is dismissed on start_workflow. #276

iegomez opened this issue Nov 30, 2023 · 1 comment

Comments

@iegomez
Copy link

iegomez commented Nov 30, 2023

I was trying to set a retry policy by passing a retry_policy hash in the options hash when calling start_workflow but it didn't work.
I went digging in the code and realized it is indeed omitted: even if the execution options are built with the policy, they are not used on the underlying call to start_workflow_execution at https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/client.rb#L43.

The only way I was able to actually set a policy was by calling retry_policy in an activity, but that leaves the caller powerless on setting a retry policy, and it seems it doesn't apply to workflows either.

Is this a regression? Was it always a bug? The readme states you can pass this option.

@nkhaled16
Copy link

Im facing the same issue, and would really appreciate if it can get fixed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants