Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial changes #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Trivial changes #22

wants to merge 6 commits into from

Conversation

comex
Copy link
Owner

@comex comex commented Dec 27, 2024

  • Fix Rustsec link in documentation.

    I forgot to push this change a year ago.

  • Suppress unexpected_cfgs warning.

    The cfg is valid as it's intended to be passed manually to rustc.

    Fixes warning: unexpected cfg condition name: manual_codegen_check #21.

  • Switch to 2018 edition to resolve warning recommending such.

    No actual code changes are necessary.

  • Trivial changes suggested by clippy.

  • Change version number to 1.3.1 and update changelog.

    To be tagged and published to Cargo once merged.

    I don't think the changes really deserve individual changelog entries.

  • Update GitHub workflow.

    • Stop using ATiltedTree/setup-rust@v1 because it apparently no longer
      exists. The runners have rustup installed by default, so use that.

    • Remove the separate cargo check job, since cargo test should
      be a superset of it.

    • Add a test on nightly with default features.

    • Add a test on MSRV (1.46) with default features.

    • Add -Dwarnings to all jobs so that the presence of any warnings
      causes the job to fail.

      For the MSRV job, this requires allowlisting an unknown_lints
      warning that's known to occur there.

      Note that newer Rust versions may cause existing code to start
      producing warnings, so there is no guarantee in general that this
      crate compiles without warnings. But it still makes sense to have
      this check in CI. If someone is making changes to this crate, they
      should fix any warnings that have cropped up.

I forgot to push this change a year ago.
The cfg is valid as it's intended to be passed manually to rustc.

Fixes #21.
To be tagged and published to Cargo once merged.

I don't think the changes really deserve individual changelog entries.
@comex comex force-pushed the trivial-changes branch 3 times, most recently from 5c2e676 to 7b1e624 Compare December 27, 2024 19:06
- Stop using ATiltedTree/setup-rust@v1 because it apparently no longer
  exists.  The runners have rustup installed by default, so use that.

- Remove the separate `cargo check` job, since `cargo test` should
  be a superset of it.

- Add a test on nightly with default features.

- Add a test on MSRV (1.46) with default features.

- Add `-Dwarnings` to all jobs so that the presence of any warnings
  causes the job to fail.

  For the MSRV job, this requires allowlisting an `unknown_lints`
  warning that's known to occur there.

  Note that newer Rust versions may cause existing code to start
  producing warnings, so there is no guarantee in general that this
  crate compiles without warnings.  But it still makes sense to have
  this check in CI.  If someone is making changes to this crate, they
  should fix any warnings that have cropped up.

- Add a run of `cargo clippy` to the stable, stable-no-default-features,
  and nightly jobs.

  Probably not useful for MSRV.

- Add a build of all fuzz targets to the stable and nightly jobs.

  Running them would probably be too expensive.

- Fix a warning in one of the fuzz targets.

- Update `fuzz/ Cargo.lock` (this happened automatically when I built
  the fuzz targets).
@comex
Copy link
Owner Author

comex commented Dec 27, 2024

Added workflow changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: unexpected cfg condition name: manual_codegen_check
1 participant