Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from upstream project #15

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Jun 19, 2024

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Oded-B and others added 11 commits May 15, 2024 16:50
* Support pagination for "List files in PR" API call
+relevant test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(automerge): implement exponential backoff

* Update internal/pkg/githubapi/github.go
* Fix > 250 char Branch name issue

Move brnach name generation to a function.
Limit original branch substing to 200 charts
Switch target paths substring to sha1 of the target paths.
Tests

* Address isssus raised in PR reivew

Rename a var
Used Repeat to avoid hardcoding long string
Made some test input **a bit** more realistic
…ATH env vars (#189)

* Document APPROVER_GITHUB_APP_ID and APPROVER_GITHUB_APP_PRIVATE_KEY_PATH
env vars

Co-authored-by: Hannes Gustafsson <hnnsgstfssn@gmail.com>
…romotion PR titles (#191)

* Add a Target Description configuration keys to provide control over
promotion PR titles

* Add tests for the new **optional** configuration key

* Provide example for PR title in doc
@Oded-B Oded-B changed the title Test PR Sync changes from upstream project Jun 19, 2024
@Oded-B Oded-B marked this pull request as ready for review June 19, 2024 14:46
Copy link

gitstream-cm bot commented Jun 19, 2024

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

Copy link

gitstream-cm bot commented Jun 19, 2024

🥷 Code experts: no user matched threshold 10

See details

To learn more about /:\ gitStream - Visit our Docs

@Oded-B Oded-B merged commit 8ca8586 into commercetools:main Jun 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants