Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting comments (pr-comments) doesn't work for fork repo #77

Open
shenxianpeng opened this issue Oct 29, 2024 · 6 comments
Open

Posting comments (pr-comments) doesn't work for fork repo #77

shenxianpeng opened this issue Oct 29, 2024 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@shenxianpeng
Copy link
Contributor

However, I'm still seeing an error in the logs when posting comments. This might be because you’re working from a forked repo (posting comments worked successfully for an unforked PR in #76).

Error posting PR comment: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment", "status": "403"}

Originally posted by @shenxianpeng in #75 (comment)

@shenxianpeng shenxianpeng added the bug Something isn't working label Oct 29, 2024
@shenxianpeng shenxianpeng changed the title Posting comments doesn't work for fork repo Posting comments (pr-comments) doesn't work for fork repo Oct 29, 2024
@StaticRocket
Copy link
Contributor

Actually unsure about this. Not sure why, but I'm seeing the same issue here:

https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/11578282553/job/32231718338

Executing on a non-forked repo.

@shenxianpeng
Copy link
Contributor Author

This is also fork repo. It is from your repo and merge to upstream repo.

@shenxianpeng
Copy link
Contributor Author

Before finding a solution for the fork repository, pr-comments option need to be disabled ☹️

@StaticRocket
Copy link
Contributor

Ah, didn't think that counted. I have another workflow that attempts to comment on PRs. Hopefully it will get updated later today and I can see if that also gets hit.

@StaticRocket
Copy link
Contributor

I should have read things a little more.

https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/

StaticRocket added a commit to StaticRocket/processor-sdk-doc that referenced this issue Oct 30, 2024
Disable the function until we have a good way to address the upstream
issue [1].

[1] commit-check/commit-check-action#77

Signed-off-by: Randolph Sapp <rs@ti.com>
@StaticRocket
Copy link
Contributor

Here's what we did for our custom workflow:

https://github.com/TexasInstruments/processor-sdk-doc/blob/master/.github/workflows/rstcheck.yml
https://github.com/TexasInstruments/processor-sdk-doc/blob/master/.github/workflows/comment.yml

So this workflow really just needs a way to save the results as an artifact (or file for use in a later step) instead of pr-comment.

@shenxianpeng shenxianpeng added the help wanted Extra attention is needed label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants