-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posting comments (pr-comments) doesn't work for fork repo #77
Comments
Actually unsure about this. Not sure why, but I'm seeing the same issue here: https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/11578282553/job/32231718338 Executing on a non-forked repo. |
This is also fork repo. It is from your repo and merge to upstream repo. |
Before finding a solution for the fork repository, pr-comments option need to be disabled |
Ah, didn't think that counted. I have another workflow that attempts to comment on PRs. Hopefully it will get updated later today and I can see if that also gets hit. |
I should have read things a little more. https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ |
Disable the function until we have a good way to address the upstream issue [1]. [1] commit-check/commit-check-action#77 Signed-off-by: Randolph Sapp <rs@ti.com>
Here's what we did for our custom workflow: https://github.com/TexasInstruments/processor-sdk-doc/blob/master/.github/workflows/rstcheck.yml So this workflow really just needs a way to save the results as an artifact (or file for use in a later step) instead of pr-comment. |
However, I'm still seeing an error in the logs when posting comments. This might be because you’re working from a forked repo (posting comments worked successfully for an unforked PR in #76).
Originally posted by @shenxianpeng in #75 (comment)
The text was updated successfully, but these errors were encountered: