Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometric Key still uses compas.PRECISION #1331

Closed
Licini opened this issue Apr 23, 2024 · 5 comments
Closed

Geometric Key still uses compas.PRECISION #1331

Licini opened this issue Apr 23, 2024 · 5 comments
Assignees
@Licini

Comments

@Licini
Copy link
Contributor

Licini commented Apr 23, 2024

No description provided.

@Licini Licini self-assigned this Apr 23, 2024
@jf---
Copy link
Contributor

jf--- commented Apr 23, 2024

@Licini can you pinpoint to a precise line of code perhaps?

@tomvanmele
Copy link
Member

compas.utilities.maps.geometric_key

it should just be removed....

@tomvanmele
Copy link
Member

as far as i can tell, they have been replaced by compas.tolerance.TOL.geometric_key everywhere.

@gonzalocasas remove?

@gonzalocasas
Copy link
Member

Yep, I think so. Ideally "(only) one way to do things"

@Licini
Copy link
Contributor Author

Licini commented Apr 24, 2024

@Licini can you pinpoint to a precise line of code perhaps?

It was this line

compas/src/compas/utilities/maps.py

Line 41 in 4aff080

precision = compas.PRECISION

And now being removed at #1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Licini Licini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jf--- @gonzalocasas @Licini @tomvanmele