Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes for visualisation parameters #1370

Open
Licini opened this issue Jun 11, 2024 · 0 comments
Open

Notes for visualisation parameters #1370

Licini opened this issue Jun 11, 2024 · 0 comments
Assignees
@Licini @tomvanmele

Comments

@Licini
Copy link
Contributor

Licini commented Jun 11, 2024 

          LGTM. just a few notes/reminders
  • show_wires (Blender) is actually the same as show_lines. show_wires is a better name in my opinion
  • disjoint (Rhino) and not shade_smooth (Blender) are the same
  • Frame, Plane, Shape, Curve, Surface should have dedicated base classes
  • points of Line, Polyline, Polygon, Polyhedron, Curve, Surface are in fact "control points" and should perhaps have a dedicated color attribute for when they are turned "on".

Originally posted by @tomvanmele in #1353 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Licini Licini

@tomvanmele tomvanmele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Licini @tomvanmele