-
Notifications
You must be signed in to change notification settings - Fork 14
docs: CPLYTM-498 add document for sync-cac-content #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CPLYTM-498 add document for sync-cac-content #434
Conversation
cc8425a
to
14a8eac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a few minor comments, but otherwise LGTM.
docs/tutorials/sync-cac-content.md
Outdated
- Populate CaC product information to Oscal component title and description | ||
- Ensure OSCAL component control mappings are populated with rule and rule parameter data from CaC control files | ||
- Create a validation component from SSG rules to check mappings | ||
- Ensure OSCAL component definition implemented requirements is populated from control notes in control file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick: Possibly rewording to "Ensure OSCAL Component Definition implemented requirements are populated from control notes in the control file. "
docs/tutorials/sync-cac-content.md
Outdated
- Ensure OSCAL component control mappings are populated with rule and rule parameter data from CaC control files | ||
- Create a validation component from SSG rules to check mappings | ||
- Ensure OSCAL component definition implemented requirements is populated from control notes in control file | ||
- Ensure implementation status of an implemented requirement in OSCAL component definitions is populated with the status from CaC control files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick: Same comment to reword from "is populated" to "are populated."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
docs/tutorials/sync-cac-content.md
Outdated
|
||
## 1. Prerequisites | ||
|
||
- Initialize the [trestlebot workplace](https://github.com/complytime/trestle-bot/blob/main/docs/tutorials/github.md#3-initialize-trestlebot-workspace). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be trestlebot workspace instead of workplace? I am not sure, but wanted to ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, workspace. Good catch!
Signed-off-by: Sophia Wang <huiwang@redhat.com>
14a8eac
to
fe1e3c4
Compare
Description
Add the document for the CLI
sync-cac-content
.Type of change
How has this been tested?
Test Configuration:
Checklist