New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that all modifications are resolvable #155

Open

RalfG opened this issue Jul 9, 2024 · 0 comments

Labels

Member

RalfG commented Jul 9, 2024

Instead of logging unmapped modifications

ms2rescore/ms2rescore/parse_psms.py

Lines 73 to 77 in e3f723d

    
           if non_mapped_modifications: 
        
               logger.warning( 
        
                   f"Non-mapped modifications found: {non_mapped_modifications}\n" 
        
                   "This can be ignored if they are Unimod modification labels." 
        
               )

check if all modifications are resolvable after mapping and report the ones that are not.

RalfG added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment