DateTimeHelper minor performance optimisation

Ivan Vasilkov · Ivan Vasilkov · commit d0bc49b97933 · 2023-12-25T08:43:42.000Z
diff --git a/src/Helpers/DateTimeHelper.php b/src/Helpers/DateTimeHelper.php
@@ -27,11 +27,11 @@ public static function isDefault(mixed $value): bool
             return true;
         }
         if ($value instanceof \DateTimeInterface) {
-            $value = self::dateTimeToString($value);
+            return $value->getTimestamp() <= 1;
         }
-        return in_array(
-            $value,
-            [self::DEFAULT_TIMESTAMP, self::DEFAULT_TIMESTAMP_MICRO, self::DEFAULT_DATETIME, self::DEFAULT_DATETIME_MICRO]
-        );
+        return $value === self::DEFAULT_TIMESTAMP
+            || $value === self::DEFAULT_TIMESTAMP_MICRO
+            || $value === self::DEFAULT_DATETIME
+            || $value === self::DEFAULT_DATETIME_MICRO;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,11 @@ public static function isDefault(mixed $value): bool`
`27`	`27`	`return true;`
`28`	`28`	`}`
`29`	`29`	`if ($value instanceof \DateTimeInterface) {`
`30`		`- $value = self::dateTimeToString($value);`
	`30`	`+ return $value->getTimestamp() <= 1;`
`31`	`31`	`}`
`32`		`- return in_array(`
`33`		`- $value,`
`34`		`- [self::DEFAULT_TIMESTAMP, self::DEFAULT_TIMESTAMP_MICRO, self::DEFAULT_DATETIME, self::DEFAULT_DATETIME_MICRO]`
`35`		`- );`
	`32`	`+ return $value === self::DEFAULT_TIMESTAMP`
	`33`	`+ \|\| $value === self::DEFAULT_TIMESTAMP_MICRO`
	`34`	`+ \|\| $value === self::DEFAULT_DATETIME`
	`35`	`+ \|\| $value === self::DEFAULT_DATETIME_MICRO;`
`36`	`36`	`}`
`37`	`37`	`}`