[BazelDeps] Adding RPATH to linkopts #19193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: [BazelDeps] Adding RPATH flag in
linkoptsfield for dynamic builds and UNIX systems.Docs: omit
Closes: #19135
Closes: #19190
Rationale
For instance, the
csmlibrary creates these binaries:And the
csm/BUILD.bazelfile has this:Any application linking with that will show this:
It points to the symlink, but Bazel only copies the matched library into its own cache (libcsmapi.dylib). Adding the rpath flag, we solve that problem.