Merge pull request #1169 from concord-consortium/188024567-set-rubric-min-rating-score

fix: Set the minimum rubric rating score to 1

Author: dougmartin

app/assets/javascripts/lara-typescript.js

@@ -139922,8 +139922,15 @@ var RubricRatingsItem = function (_a) {
     }));
   }, [rating]);
   var handleScoreUpdate = (0, react_1.useCallback)(function (e) {
+    // don't allow scores less than 1
+    var newScore = parseInt(e.target.value, 10);
+
+    if (isNaN(newScore) || newScore < 1) {
+      newScore = 1;
+    }
+
     onUpdate(index, __assign(__assign({}, rating), {
-      score: parseInt(e.target.value, 10)
+      score: newScore
     }));
   }, [rating]);
   return React.createElement("tr", null, React.createElement("td", null, React.createElement("input", {
@@ -139938,7 +139945,8 @@ var RubricRatingsItem = function (_a) {
   })), React.createElement("td", null, React.createElement("input", {
     value: score,
     type: "number",
-    onChange: handleScoreUpdate
+    onChange: handleScoreUpdate,
+    min: 1
   })), React.createElement("td", null, React.createElement(trash_1.Trash, {
     onClick: handleDelete
   })));
@@ -139980,7 +139988,7 @@ var RubricRatings = function () {
       draft.ratings.push({
         id: "R" + (draft.ratings.length + 1),
         label: "",
-        score: 0
+        score: 1
       });
     });
   };

lara-typescript/src/rubric-authoring/rubric-ratings.tsx

@@ -23,14 +23,19 @@ export const RubricRatingsItem = ({index, rating, onDelete, onUpdate}: IRubricRa
     onUpdate(index, {...rating, label: e.target.value});
   }, [rating]);
   const handleScoreUpdate = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
-    onUpdate(index, {...rating, score: parseInt(e.target.value, 10)});
+    // don't allow scores less than 1
+    let newScore = parseInt(e.target.value, 10);
+    if (isNaN(newScore) || newScore < 1) {
+      newScore = 1;
+    }
+    onUpdate(index, {...rating, score: newScore});
   }, [rating]);
 
   return (
     <tr>
       <td><input value={id} type="text" disabled={true} /></td>
       <td><input value={label} type="text" autoFocus={true} onChange={handleLabelUpdate} /></td>
-      <td><input value={score} type="number" onChange={handleScoreUpdate} /></td>
+      <td><input value={score} type="number" onChange={handleScoreUpdate} min={1} /></td>
       <td><Trash onClick={handleDelete} /></td>
     </tr>
   );
@@ -63,7 +68,7 @@ export const RubricRatings = () => {
 
   const handleAdd = () => {
     setRubric(draft => {
-      draft.ratings.push({id: `R${draft.ratings.length + 1}`, label: "", score: 0});
+      draft.ratings.push({id: `R${draft.ratings.length + 1}`, label: "", score: 1});
     });
   };