Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing React.memo test #17

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Add failing React.memo test #17

merged 2 commits into from
Jan 12, 2019

Conversation

billyjanitsch
Copy link
Contributor

Failing test to demonstrate #16.

Removing .failing from the test causes concordance to crash with this error:

  Error thrown in test:

  TypeError {
    message: 'Unexpected value with type 0xOBJECT',
  }

  encodeValue (node_modules/concordance/lib/encoder.js:91:9)
  encodeValue (node_modules/concordance/lib/encoder.js:86:13)
  Object.encode (node_modules/concordance/lib/encoder.js:240:31)
  serialize (node_modules/concordance/lib/serialize.js:232:18)
  useDeserialized (test/serialize-and-encode.js:15:18)

@billyjanitsch billyjanitsch mentioned this pull request Nov 26, 2018
Open
@novemberborn novemberborn merged commit 5e2b624 into concordancejs:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyjanitsch @novemberborn