Skip to content

Commit 70e97f8

Browse files
committed
skip instead of failing if test vars aren't set
1 parent 0cc81e7 commit 70e97f8

File tree

3 files changed

+30
-16
lines changed

3 files changed

+30
-16
lines changed

check/check_suite_test.go

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@ var v2signing = os.Getenv("SEMVER_TESTING_V2_SIGNING") == "true"
1919

2020
var _ = BeforeSuite(func() {
2121
var err error
22-
23-
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
24-
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
25-
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
26-
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
27-
2822
if _, err = os.Stat("/opt/resource/check"); err == nil {
2923
checkPath = "/opt/resource/check"
3024
} else {
@@ -33,6 +27,17 @@ var _ = BeforeSuite(func() {
3327
}
3428
})
3529

30+
var _ = BeforeEach(func() {
31+
if accessKeyID == "" || secretAccessKey == "" {
32+
Skip("no bucket configuration; skipping")
33+
}
34+
35+
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
36+
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
37+
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
38+
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
39+
})
40+
3641
var _ = AfterSuite(func() {
3742
gexec.CleanupBuildArtifacts()
3843
})

in/in_suite_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ var v2signing = os.Getenv("SEMVER_TESTING_V2_SIGNING") == "true"
2020
var _ = BeforeSuite(func() {
2121
var err error
2222

23-
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
24-
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
25-
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
26-
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
27-
2823
if _, err = os.Stat("/opt/resource/in"); err == nil {
2924
inPath = "/opt/resource/in"
3025
} else {
@@ -34,6 +29,14 @@ var _ = BeforeSuite(func() {
3429
})
3530

3631
var _ = BeforeEach(func() {
32+
if accessKeyID == "" || secretAccessKey == "" {
33+
Skip("no bucket configuration; skipping")
34+
}
35+
36+
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
37+
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
38+
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
39+
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
3740
})
3841

3942
var _ = AfterSuite(func() {

out/out_suite_test.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ var v2signing = os.Getenv("SEMVER_TESTING_V2_SIGNING") == "true"
2020
var _ = BeforeSuite(func() {
2121
var err error
2222

23-
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
24-
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
25-
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
26-
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
27-
2823
if _, err = os.Stat("/opt/resource/out"); err == nil {
2924
outPath = "/opt/resource/out"
3025
} else {
@@ -33,6 +28,17 @@ var _ = BeforeSuite(func() {
3328
}
3429
})
3530

31+
var _ = BeforeEach(func() {
32+
if accessKeyID == "" || secretAccessKey == "" {
33+
Skip("no bucket configuration; skipping")
34+
}
35+
36+
Expect(accessKeyID).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_ACCESS_KEY_ID")
37+
Expect(secretAccessKey).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_SECRET_ACCESS_KEY")
38+
Expect(bucketName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_BUCKET")
39+
Expect(regionName).NotTo(BeEmpty(), "must specify $SEMVER_TESTING_REGION")
40+
})
41+
3642
var _ = AfterSuite(func() {
3743
gexec.CleanupBuildArtifacts()
3844
})

0 commit comments

Comments
 (0)