-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies on pillow and anaconda-project #49
Comments
@vshevchenko-anaconda would be interested to hear your thoughts here? Also curious to know whether these dependencies could be softened upstream |
(N.B.: If/when we do this, we have to coordinate this with @isuruf since it affects other infrastructure things he works on.) |
What are Pillow and Anaconda-Project used for? Asking to understand how this would affect other things |
Those are comparatively niche uses so inclusion by default has less benefit in comparison to improved resource usage. For comparison, https://github.com/AnacondaRecipes/anaconda-client-feedstock/blob/9b0bfa3b9fec973b4911cf65efcb4e997d2c3db8/recipe/meta.yaml#L29 also does not include those by default. |
Support for both will be removed in future anaconda.org as mentioned in the last meeting. |
Ah, nice, thanks for mentioning that! |
Projects, notebooks, and environments are being removed Don't recall them mentioning icons. That said, Idk whether these see much usage now |
Comment:
In #36
from https://github.com/Anaconda-Platform/anaconda-client/blob/1.11.1/requirements-extra.txt have been added as hard dependencies.
This is generally fine since it is common for conda-forge packages to ship optional dependencies by default.
In this case though, we drag in some unneeded/unwanted baggage for all our CI runs since our infrastructure depends on this packages.
Concrete, we have
pillow
itself which is a unreasonably large (over 40MB) package since Included tests make the package large pillow-feedstock#117 has not been resolved.anaconda-project
(transitively) drags in 22 more dependencies (currently on:linux-64
when creating a fresh environment)nearly all those dependencies are small,but it also includespillow
, i.e., see above,anaconda-project
depending onanaconda-client
itself;so, we may just want to remove that cyclic dependency,
ruamel_yaml
which I'd like to remove generally.(As for the last point, I've opened a PR orthogonal to this issue to switch
anaconda-project
toruamel.yaml
at anaconda/anaconda-project#399 .)Could we either remove this dependencies again or create a sub package
anaconda-client-XXX
which does not include those?The text was updated successfully, but these errors were encountered: