Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all hints shown when running conda smithy lint recipe locally #2043

Open
h-vetinari opened this issue Aug 29, 2024 · 4 comments
Open

Not all hints shown when running conda smithy lint recipe locally #2043

h-vetinari opened this issue Aug 29, 2024 · 4 comments

Comments

@h-vetinari
Copy link
Member

I'm often linting locally before pushing to avoid creating noisy linter comments upon pushing to a PR, however, it seems the new warning about missing pip build dependencies doesn't show up when doing so. Running the linter locally (conda-smithy 3.39.0) for conda-forge/cython-feedstock#143 says "recipe is in fine form", while the actual linter complains.

Other hints (like the SPDX identifier) do get shown, so it's not about hint vs. error. This is on a windows machine, in case that matters.

@h-vetinari
Copy link
Member Author

Bizarrely, github shows that there's been a comment here

image

...but I cannot see anything:

image

In case I missed a response somehow, please readd it.

@h-vetinari
Copy link
Member Author

@beckermr, any idea why the setuptools check wouldn't run locally (resp. on windows)?

@isuruf
Copy link
Member

isuruf commented Sep 3, 2024

You need to do conda smithy recipe-lint recipe --conda-forge

@h-vetinari
Copy link
Member Author

Ah, ok, that's new to me, but not a problem to add an argument of course. However, that currently also fails with a missing GH_TOKEN env var, and setting it to a dummy value doesn't help. I guess I need to set up my own API token...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@isuruf @h-vetinari and others