Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lief specific code to use less memory, be less complex #4380

Open
jezdez opened this issue Feb 14, 2022 · 2 comments
Open

Refactor lief specific code to use less memory, be less complex #4380

jezdez opened this issue Feb 14, 2022 · 2 comments
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release help-wanted we don't know the solution or we especially want a community member to contribute the code change severity::4 low; functionality is inconvenient source::governance created by members of the conda governance (https://github.com/conda-incubator/governance) stale::recovered [bot] recovered after being marked as stale type::tech-debt identifies or resolves some technical debt

Comments

@jezdez
Copy link
Member

jezdez commented Feb 14, 2022

To quote @xhochy on Slack:

There is some code in conda-build that holds on to too much Lief information. In the master branch of Lief, these data structures are a lot smaller and thus I haven’t had an issue in most cases. It’s only that we cannot build ghc for ppc64le currently in CI as even lief_dev errors with out-of-memory. The code in conda-build is sadly quite complex and we would need to rewrite it so that it doesn’t hand plain lief objects around but e.g. dataclasses with only the necessary bits. (edited)
@beeankha beeankha added source::anaconda created by members of Anaconda, Inc. severity::3 major; broken functionality with a workaround source::contributor created by a frequent contributor type::bug describes erroneous operation, use severity::* to classify the type type::tech-debt identifies or resolves some technical debt severity::4 low; functionality is inconvenient source::governance created by members of the conda governance (https://github.com/conda-incubator/governance) and removed source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type severity::3 major; broken functionality with a workaround source::contributor created by a frequent contributor labels Feb 15, 2022
@beeankha beeankha added the backlog issue has been triaged but has not been earmarked for any upcoming release label Feb 24, 2022
@jezdez jezdez added the help-wanted we don't know the solution or we especially want a community member to contribute the code change label May 5, 2022
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jun 24, 2023
@jakirkham
Copy link
Member

(bump)

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release help-wanted we don't know the solution or we especially want a community member to contribute the code change severity::4 low; functionality is inconvenient source::governance created by members of the conda governance (https://github.com/conda-incubator/governance) stale::recovered [bot] recovered after being marked as stale type::tech-debt identifies or resolves some technical debt
Projects
🧭 Planning
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jezdez @jakirkham @beeankha