Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jinja2 checks since it is already an explicit dependency #5497

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Sep 18, 2024

Description

Found some try-except clauses around jinja2 imports. These are no longer necessary (or desired) since jinja2 is a hard dependency of conda-build and will always be present.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 18, 2024
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #5497 will not alter performance

Comparing kenodegard:move-jinja2 (a164aa9) with main (0ef3749)

Summary

✅ 5 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review September 19, 2024 22:14
@kenodegard kenodegard requested a review from a team as a code owner September 19, 2024 22:14
beeankha
beeankha previously approved these changes Sep 20, 2024
news/TEMPLATE Outdated Show resolved Hide resolved
@beeankha beeankha merged commit 655e5bc into conda:main Oct 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants