Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for new output format #486

Open
marcelotrevisani opened this issue Sep 15, 2023 · 9 comments
Open

[FEATURE] Add support for new output format #486

marcelotrevisani opened this issue Sep 15, 2023 · 9 comments

Comments

@marcelotrevisani
Copy link
Member

https://github.com/prefix-dev/recipe-format

Add feature to generate recipe in this new format.

cc: @wolfv @ocefpaf

It would be nice to add more examples so it would be easier to add this. :)

@marcelotrevisani marcelotrevisani added enhancement New feature or request feature labels Sep 15, 2023
@wolfv
Copy link

wolfv commented Sep 18, 2023

Awesome! Would love to see this.
We don't have so many examples of the new format available yet. We have some examples of the previous variant in the emscripten-forge and boa-forge repositories:

@beenje
Copy link
Contributor

beenje commented Jan 15, 2024

Currently using grayskull + boa convert + some sed to feed the new recipe to rattler-build.
Would love to have support in grayskull directly :-)

If nobody started working on this yet, I could give it a try in the coming weeks (no promise).
Haven't looked yet, but should most work be in https://github.com/marcelotrevisani/souschef ?

@wolfv
Copy link

wolfv commented Jan 15, 2024

That would be amazing. No one is working on it afaik :)

@schuylermartin45
Copy link
Contributor

Now that the conda-recipe-manager is up and running with conversion integration tests with rattler-build, should we consider having grayskull incorporate conda-recipe-manager as the translation layer? At least as a first-pass implementation?

@marcelotrevisani
Copy link
Member Author

Yes, sure
I just don't have the capacity now for that, due to some personal and work obligations.
However, I can review the PR
If you would like to give a try please let me know :)

@schuylermartin45
Copy link
Contributor

I might be able to start on this next week. I have some low-hanging fruit that'll improve compatibility with rattler-build I want to address and then I should be free to take a look.

schuylermartin45 added a commit to schuylermartin45/staged-recipes that referenced this issue May 15, 2024
- This will allow us to start publishing versions that others can consume
- The most immediate need is for an [ask in Grayskull](conda/grayskull#486)
@schuylermartin45
Copy link
Contributor

Not to set myself up for failure, but this looks relatively straight-forward so far. This will be the first project that consumes conda-recipe-manager, so I'm sure there will be some unexpected hurdles.

My current plan is to add a new flag to grayskull. If it is set, perform the conversion in utils.generate_recipe() before we dump the recipe contents. I'll also automatically use recipe.yaml over meta.yaml where applicable.

@schuylermartin45
Copy link
Contributor

I put up a draft PR until I can get unblocked on a few things. See my PR description for more details.

@schuylermartin45
Copy link
Contributor

I put up a draft PR until I can get unblocked on a few things. See my PR description for more details.

This PR is now out of Draft. I found a workaround to the plugin issue I was encountering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants