You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have recently tried running JOIN tasks synchronously in Conductor. To do this we made a small change to WorkflowExecutorOps.isLazyEvaluateWorkflow and updated the JOIN task to return isAsync = false.
Our reason for switching to sync are
predictable completion of the JOIN without the need to tune any settings
reduction in JOIN executions for long running JOINs
Describe Preferred Solution
Make existing JOIN task sync
Pros
simple change
likely will be more performant for the majority
Cons
maybe some use cases it results in more JOIN executions
Describe Alternatives
Have the JOIN task be driven by a system property
Pros
this is an fairly simple change
gives consumers the option, although still a single setting for all JOINs
Cons
may make maintenance of execution. logic more complicated
Have the JOIN task be either async or sync based on TaskDef
would require isAsync to be passed the task which won’t work initializing queues
might need to introduce a new method supportsAsync()
Pros
this is a flexible solution allowing workflow owners to choose
Cons
more complexity in making this change
Have both a sync and non sync JOIN task
any conditional logic related to execution of JOINS will not be able to use the TaskType there will need to be another attribute of
tasks i.e. WorkerSystemTask.isJoin()
Pros
this is a flexible solution allowing workflow owners to choose which JOIN they use
Cons
more complexity in making this change
The text was updated successfully, but these errors were encountered:
Describe the Feature Request
We have recently tried running JOIN tasks synchronously in Conductor. To do this we made a small change to WorkflowExecutorOps.isLazyEvaluateWorkflow and updated the JOIN task to return isAsync = false.
Our reason for switching to sync are
Describe Preferred Solution
Make existing JOIN task sync
Pros
Cons
Describe Alternatives
Pros
Cons
Pros
Cons
tasks i.e. WorkerSystemTask.isJoin()
Pros
Cons
The text was updated successfully, but these errors were encountered: