Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attestation-Service: replacing anyhow with explicit error types #231

Closed
mkulke opened this issue Nov 21, 2023 · 1 comment · Fixed by #327 or #330 · May be fixed by #326 or #328
Closed

Attestation-Service: replacing anyhow with explicit error types #231

mkulke opened this issue Nov 21, 2023 · 1 comment · Fixed by #327 or #330 · May be fixed by #326 or #328
Assignees
@kartikjoshi21

Comments

@mkulke
Copy link
Contributor

mkulke commented Nov 21, 2023

In a library crate it's better to specify expected error types explicitly rather than relying on generic anyhow errors. thiserror is a crate by the same author, which allows doing this in a convenient fashion.
mkulke added a commit to mkulke/trustee that referenced this issue Nov 22, 2023
@mkulke
attestation-service: fix checks for VCEK signature
8598c11 
Similar to confidential-containers#230 the verify function here is actually not checking the
result of the verification.

There is a fail-test for the vcek signature verification, but it fails
at parsing the DER cert. We should get rid of anyhow here and use proper
error types (confidential-containers#231) which we can then assert in such tests.

- Fixed the verification logic
- Added test-case for toggled ark-ask
- Fixed fail-test to produce a legit VCEK

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke mentioned this issue Nov 22, 2023
Merged
@mkulke mkulke changed the title Attestation-Service: consider replacing anyhow Attestation-Service: replacing anyhow with explicit error types Nov 22, 2023
mkulke added a commit to mkulke/trustee that referenced this issue Nov 23, 2023
@mkulke
attestation-service: fix checks for VCEK signature
9461479 
Similar to confidential-containers#230 the verify function here is actually not checking the
result of the verification.

There is a fail-test for the vcek signature verification, but it fails
at parsing the DER cert. We should get rid of anyhow here and use proper
error types (confidential-containers#231) which we can then assert in such tests.

- Fixed the verification logic
- Added test-case for toggled ark-ask
- Fixed fail-test to produce a legit VCEK

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke added a commit to mkulke/trustee that referenced this issue Nov 23, 2023
@mkulke
attestation-service: fix check for AMD signatures
84ab9d3 
Similar to confidential-containers#230 the verify function here is actually not checking the result
of the verification.

There is a fail-test for the vcek signature verification, but it fails at
parsing the DER cert. We should get rid of anyhow here and use proper error
types (confidential-containers#231) which we can then assert in such tests.

- Fixed the verification logic
- Added test-case for toggled ark-ask
- Fixed fail-test to produce a legit VCEK

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
Xynnn007 pushed a commit that referenced this issue Nov 23, 2023
@mkulke @Xynnn007
attestation-service: fix check for AMD signatures
c7367c0 
Similar to #230 the verify function here is actually not checking the result
of the verification.

There is a fail-test for the vcek signature verification, but it fails at
parsing the DER cert. We should get rid of anyhow here and use proper error
types (#231) which we can then assert in such tests.

- Fixed the verification logic
- Added test-case for toggled ark-ask
- Fixed fail-test to produce a legit VCEK

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@kartikjoshi21
Copy link
Contributor

@Xynnn007 please assign this one to me. Thanks

kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 15, 2024
@kartikjoshi21
Verifier: Refactor errors in cca module
a395ea7 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@kartikjoshi21 kartikjoshi21 mentioned this issue Feb 15, 2024
Open
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 15, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
75c19bd 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@kartikjoshi21 kartikjoshi21 mentioned this issue Feb 15, 2024
Merged
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 15, 2024
@kartikjoshi21
Verifier: Refactor errors in sgx module
4c83e26 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@kartikjoshi21 kartikjoshi21 mentioned this issue Feb 15, 2024
Open
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 15, 2024
@kartikjoshi21
Verifier: Refactor errors in csv module
61cf6be 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@kartikjoshi21 kartikjoshi21 mentioned this issue Feb 15, 2024
Merged
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 22, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
693500c 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 22, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
1e3a7d4 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 26, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
6c47bef 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 26, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
57e7d2e 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 27, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
043155e 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Feb 29, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
4f3e97e 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 11, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
be0d242 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 11, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
4a8f6b3 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 12, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
7fb301b 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 12, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
223a62d 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 12, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
3fdc977 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 19, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
8fae94b 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 19, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
e5fa0a5 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 19, 2024
@kartikjoshi21
Verifier: Refactor errors in sgx module
73c42e9 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 19, 2024
@kartikjoshi21
Verifier: Refactor errors in csv module
e924b87 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 19, 2024
@kartikjoshi21
Verifier: Refactor errors in csv module
eec3819 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 20, 2024
@kartikjoshi21
attestation-service: Replace anyhow error crate with thiserror crate
698ddc3 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
sameo pushed a commit that referenced this issue Mar 24, 2024
@kartikjoshi21 @sameo
Verifier: Refactor errors in csv module
11bac3e 
Fixes: #231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 26, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
2796ad4 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 26, 2024
@kartikjoshi21
Azsnpvtpm: Replace anyhow error crate with thiserror crate
2f367cf 
Replace anyhow error crate with thiserror crate
Fixes: confidential-containers#231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/kbs that referenced this issue Mar 26, 2024
@kartikjoshi21
Verifier: Refactor errors in sgx module
2ae8a8f 
Fixes: confidential-containers#231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
jialez0 pushed a commit that referenced this issue Apr 10, 2024
@kartikjoshi21 @jialez0
attestation-service: Replace anyhow error crate with thiserror crate
7a74faa 
Fixes: #231
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
jialez0 pushed a commit that referenced this issue Apr 10, 2024
@kartikjoshi21 @jialez0
Azsnpvtpm: Replace anyhow error crate with thiserror crate
2e28d19 
Replace anyhow error crate with thiserror crate
Fixes: #231

Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartikjoshi21 kartikjoshi21

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mkulke @kartikjoshi21