Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Makefile with turborepo #798

Closed
timostamm opened this issue Aug 31, 2023 · 1 comment · Fixed by #1194
Closed

Replace Makefile with turborepo #798

timostamm opened this issue Aug 31, 2023 · 1 comment · Fixed by #1194
Labels
cleanup Cleanup tasks

Comments

@timostamm
Copy link
Member

This repository is using a Makefile because it initially used Go for code generation.

We have most tools available as npm packages by now, and in connectrpc/connect-playwright-es, we switched to a new turborepo setup we want to standardize on.

The plan is to switch this repository to the same setup, which should give us a decent speedup in CI and local development, and also make it easier for contributors to get started.

There are two remaining complications:

  • Conformance tests are currently run against Docker servers, and we need to make sure they are running during tests.
  • We are running some (but not all) test suites on several versions of Node.js. The best way forward is likely to use the setup-node action with a matrix in the CI workflow instead.
@timostamm timostamm added the cleanup Cleanup tasks label Aug 31, 2023
@srikrsna-buf srikrsna-buf changed the title Replace Makefile with with turborepo Replace Makefile with turborepo Oct 2, 2023
@timostamm
Copy link
Member Author

timostamm commented Jun 19, 2024

The two complications are eliminated with #1103 and #1110.

There's a (small) new one with #1079 (review). Fixed by #1111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant