Throw an error on missing status in gRPC and gRPC-Web transports #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
srikrsna-buf
commented
Sep 3, 2024
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
reviewed
Sep 5, 2024
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
reviewed
Sep 10, 2024
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an error on missing status in gRPC and gRPC-Web transports.
In node, there is no way to tell if a server terminated with
RST_STREAMwith codeNO_ERRORor a regular close. This is causing such closures to not be reported. Checking to see if we received the trailers with the status code will result in the same case. This closes #1108.This change also triggered a minor conformance failure of unsupported header check, so this PR also adds the check to gRPC transport. We continue to omit this for gRPC-Web for compatibility with other gRPC-Web libraries