Update Node.js versions #1207
Merged
Update Node.js versions #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timostamm
commented
Sep 3, 2024
timostamm
commented
- Add v22.7.0
- Update v20 to 20.17.0
- Update v18 to 18.20.4
- Update v16 to 16.20.2
- Remove v21 - it's not an LTS and no longer supported
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Sep 3, 2024
| @@ -69,20 +69,6 @@ describe("compression", () => { | |||
| ); | |||
| } | |||
| }); | |||
| it("should raise internal error on excessive readMaxBytes", async () => { | |||
There was a problem hiding this comment.
This test ensures that we raise the error code "internal" if the readMaxBytes argument passed to decompress() is larger than what the decompressor supports.
We just had to update the implementation because error codes changed in a minor, and v22 would require us to change it again.
readMaxBytes is a configuration option that's verified elsewhere to be in bounds, so I think it's best we just remove this test.
srikrsna-buf
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.