From 22ff5aa5910c92a731e0c5e2fc5f519cc95851e6 Mon Sep 17 00:00:00 2001
From: Timo Stamm <ts@timostamm.de>
Date: Tue, 3 Sep 2024 16:35:24 +0200
Subject: [PATCH 1/2] Update Node.js versions

Signed-off-by: Timo Stamm <ts@timostamm.de>
---
 .github/workflows/ci.yaml                  | 4 ++--
 .github/workflows/conformance-express.yaml | 2 +-
 .github/workflows/conformance-fastify.yaml | 2 +-
 .github/workflows/conformance-node.yaml    | 2 +-
 .github/workflows/conformance-web.yaml     | 2 +-
 .nvmrc                                     | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 32191db28..1cb788112 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -60,7 +60,7 @@ jobs:
         # Node.js v16 does not provide all necessary fetch types by default, so
         # we cannot run tests for @connectrpc/connect-web.
         # v16 is tested in a separate job below.
-        node-version: [21.1.0, 20.9.0, 18.16.0]
+        node-version: [22.7.0, 20.17.0, 18.20.4]
     name: "test on Node.js ${{ matrix.node-version }}"
     steps:
       - uses: actions/checkout@v4
@@ -80,7 +80,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.20.0]
+        node-version: [16.20.2]
     name: "test on Node.js ${{ matrix.node-version }}"
     steps:
       - uses: actions/checkout@v4
diff --git a/.github/workflows/conformance-express.yaml b/.github/workflows/conformance-express.yaml
index 77533b0b0..1ffd8f0f8 100644
--- a/.github/workflows/conformance-express.yaml
+++ b/.github/workflows/conformance-express.yaml
@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [21.1.0, 20.9.0, 18.16.0]
+        node-version: [22.7.0, 20.17.0, 18.20.4, 16.20.2]
     name: "Node.js ${{ matrix.node-version }}"
     timeout-minutes: 10
     steps:
diff --git a/.github/workflows/conformance-fastify.yaml b/.github/workflows/conformance-fastify.yaml
index cd903cb56..7c4ae2fae 100644
--- a/.github/workflows/conformance-fastify.yaml
+++ b/.github/workflows/conformance-fastify.yaml
@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [21.1.0, 20.9.0, 18.16.0]
+        node-version: [22.7.0, 20.17.0, 18.20.4, 16.20.2]
     name: "Node.js ${{ matrix.node-version }}"
     timeout-minutes: 10
     steps:
diff --git a/.github/workflows/conformance-node.yaml b/.github/workflows/conformance-node.yaml
index bcec39217..90d32c286 100644
--- a/.github/workflows/conformance-node.yaml
+++ b/.github/workflows/conformance-node.yaml
@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [21.1.0, 20.9.0, 18.16.0]
+        node-version: [22.7.0, 20.17.0, 18.20.4, 16.20.2]
         side: [client, server]
     name: "Node.js ${{ matrix.node-version }} ${{ matrix.side }}"
     timeout-minutes: 10
diff --git a/.github/workflows/conformance-web.yaml b/.github/workflows/conformance-web.yaml
index a0a1afa23..2d1562c45 100644
--- a/.github/workflows/conformance-web.yaml
+++ b/.github/workflows/conformance-web.yaml
@@ -47,7 +47,7 @@ jobs:
     strategy:
       matrix:
         # Node.js v16 does not provide all necessary fetch types by default
-        node-version: [21.1.0, 20.9.0, 18.16.0]
+        node-version: [22.7.0, 20.17.0, 18.20.4, 18.16.0]
         client: [promise, callback]
     name: "Node.js ${{ matrix.node-version }} ${{ matrix.client }}"
     timeout-minutes: 10
diff --git a/.nvmrc b/.nvmrc
index f3f52b42d..3516580bb 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-20.9.0
+20.17.0

From 697a4ea41a417e2583a8d4b37ea865936d79c95f Mon Sep 17 00:00:00 2001
From: Timo Stamm <ts@timostamm.de>
Date: Tue, 3 Sep 2024 17:15:26 +0200
Subject: [PATCH 2/2] Remove test for compression

Signed-off-by: Timo Stamm <ts@timostamm.de>
---
 packages/connect-node/src/compression.spec.ts | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/packages/connect-node/src/compression.spec.ts b/packages/connect-node/src/compression.spec.ts
index 4aeaf65fd..618d7653b 100644
--- a/packages/connect-node/src/compression.spec.ts
+++ b/packages/connect-node/src/compression.spec.ts
@@ -69,20 +69,6 @@ describe("compression", () => {
           );
         }
       });
-      it("should raise internal error on excessive readMaxBytes", async () => {
-        try {
-          await compression.decompress(
-            new Uint8Array([0xde, 0xad, 0xbe, 0xef]),
-            Number.MAX_SAFE_INTEGER,
-          );
-          fail("excepted an error");
-        } catch (e) {
-          expect(e).toBeInstanceOf(ConnectError);
-          expect(ConnectError.from(e).message).toBe(
-            "[internal] decompression failed",
-          );
-        }
-      });
     });
   }
 });