Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename argument for the sessionProvider option for the Node HTTP client #1210

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

timostamm
Copy link
Member

The universal Node HTTP client takes the option sessionProvider to create a HTTP/2 session for a given URL. The argument for the URL is named "authority", which is confusing. While it makes sense to manage sessions by authority, the argument is the full URL.

@timostamm timostamm merged commit 3a291fd into main Sep 5, 2024
47 checks passed
@timostamm timostamm deleted the tstamm/rename-session-provider-arg branch September 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants