Merge pull request #245 from aik099/trailing-question-mark-in-get-requests-fix

Don't send trailing "?" in GET API urls without parameters

Author: aik099

src/Jira/Api/Client/CurlClient.php

@@ -77,7 +77,7 @@ public function sendRequest(
 
 		$curl = curl_init();
 
-		if ( $method == 'GET' ) {
+		if ( $method == 'GET' && $data ) {
 			if ( !is_array($data) ) {
 				throw new \InvalidArgumentException('Data must be an array.');
 			}

src/Jira/Api/Client/PHPClient.php

@@ -151,7 +151,7 @@ public function sendRequest(
 			$context['http']['header'] = implode("\r\n", $header);
 			$context['http']['content'] = $__data;
 		}
-		elseif ( $method == 'GET' ) {
+		elseif ( $method == 'GET' && $data ) {
 			if ( !is_array($data) ) {
 				throw new \InvalidArgumentException('Data must be an array.');
 			}

tests/Jira/Api/Client/AbstractClientTestCase.php

@@ -243,6 +243,13 @@ public static function emptyResponseWithKnownHttpCodeDataProvider()
 		);
 	}
 
+	public function testNoTrailingQuestionMarkInGetRequests()
+	{
+		$trace_result = $this->traceRequest(Api::REQUEST_GET);
+
+		$this->assertEquals('/', substr($trace_result['_SERVER']['REQUEST_URI'], -1), 'Incorrect URI ending symbol');
+	}
+
 	/**
 	 * Checks, that request contained specified content type.
 	 *