Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler throw errors after pr #365 merged #368

Closed
zhaodiaoer opened this issue Jan 21, 2025 · 2 comments
Closed

Compiler throw errors after pr #365 merged #368

zhaodiaoer opened this issue Jan 21, 2025 · 2 comments

Comments

@zhaodiaoer
Copy link
Contributor

After #365 merged, i got many error from compiler in my develop environment:

error[E0277]: the trait bound `std::boxed::Box<<T as asynchronous::Shim>::T>: containerd_shim_protos::shim_async::Task` is not satisfied
   --> crates/shim/src/asynchronous/mod.rs:181:44
    |
181 |             let task_service = create_task(Arc::new(Box::new(task)));
    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `containerd_shim_protos::shim_async::Task` is not implemented for `std::boxed::Box<<T as asynchronous::Shim>::T>`

All error gone away after just roll back this change, when read some context from #363 , i guess maybe some error originated from CI environment config, if rust version which CI job used not 1.81.0 ?

Kindly ping @jokemanfire ,#367 maybe want to fix the same problem.

@zhaodiaoer zhaodiaoer changed the title Compiler throw error after pr #365 merged Compiler throw errors after pr #365 merged Jan 21, 2025
@jokemanfire
Copy link
Contributor

Indeed, it is. I want to fix #366 . But I found compile has some problems.

@analytically
Copy link

Fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants