From ca3504165f587b2d100c8e46c5f26252e23048b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= <mitr@redhat.com>
Date: Wed, 13 Mar 2024 21:58:07 +0100
Subject: [PATCH] FIXME: BIC tests
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
---
 pkg/blobinfocache/internal/test/test.go | 8 ++++++--
 pkg/blobinfocache/sqlite/sqlite.go      | 3 ++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/pkg/blobinfocache/internal/test/test.go b/pkg/blobinfocache/internal/test/test.go
index cf5da09921..2247ee6605 100644
--- a/pkg/blobinfocache/internal/test/test.go
+++ b/pkg/blobinfocache/internal/test/test.go
@@ -197,8 +197,9 @@ func assertCandidatesMatch2(t *testing.T, scopeName string, expected []candidate
 			Digest:               ev.d,
 			CompressionOperation: op,
 			CompressionAlgorithm: algo,
-			UnknownLocation:      false,
-			Location:             types.BICLocationReference{Opaque: scopeName + ev.lr},
+			// FIXME: CompressionAnnotations are probably going to be necessary.
+			UnknownLocation: false,
+			Location:        types.BICLocationReference{Opaque: scopeName + ev.lr},
 		}
 	}
 	assertCandidatesMatch2Native(t, e, actual)
@@ -513,6 +514,8 @@ func testGenericCandidateLocations2(t *testing.T, cache blobinfocache.BlobInfoCa
 
 		// Tests of candidate filtering
 		// ----------------------------
+		// FIXME: Set chunked correctly, incl. annotations
+		// FIXME: Test expected annotations.
 		for _, e := range digestNameSetFiltering {
 			cache.RecordKnownLocation(transport, scope, e.d, types.BICLocationReference{Opaque: scopeName + e.n})
 		}
@@ -553,6 +556,7 @@ func testGenericCandidateLocations2(t *testing.T, cache blobinfocache.BlobInfoCa
 		}, res)
 
 		// Compression algorithm filters
+		// FIXME: Test zstd / chunked relationship and uses
 		res = cache.CandidateLocations2(transport, scope, digestFilteringUncompressed, blobinfocache.CandidateLocations2Options{
 			CanSubstitute:       true,
 			RequiredCompression: &compression.Gzip,
diff --git a/pkg/blobinfocache/sqlite/sqlite.go b/pkg/blobinfocache/sqlite/sqlite.go
index 15f5f99441..9d99edeafd 100644
--- a/pkg/blobinfocache/sqlite/sqlite.go
+++ b/pkg/blobinfocache/sqlite/sqlite.go
@@ -162,7 +162,8 @@ func transaction[T any](sqc *cache, fn func(tx *sql.Tx) (T, error)) (T, error) {
 		return db, func() { db.Close() }, nil
 	}()
 	if err != nil {
-		var zeroRes T // A zero value of T
+		logrus.Errorf("SQL error %v", err) // FIXME: DROP?
+		var zeroRes T                      // A zero value of T
 		return zeroRes, err
 	}
 	defer closeDB()