Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dir: sources don’t reject unknown versions #1876

Open
mtrmac opened this issue Mar 7, 2023 · 0 comments
Open

dir: sources don’t reject unknown versions #1876

mtrmac opened this issue Mar 7, 2023 · 0 comments
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 7, 2023

In fact, dirImageSource doesn’t access ref.versionPath at all.

This means we wouldn’t reject future incompatible versions — OTOH enforcing a version number could plausibly break existing scripts that manually generate dir: directories; so I guess we should assume that no version file = the current version as of today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtrmac